Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8533030: Cleanup: Remove forward declarations in various chrome/browser directories. (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
CC:
chromium-reviews, GeorgeY, cbentzel+watch_chromium.org, creis+watch_chromium.org, tburkard+watch_chromium.org, jam, Erik does not do reviews, brettw-cc_chromium.org, kkania, mihaip+watch_chromium.org, Aaron Boodman, dominich+watch_chromium.org, ajwong+watch_chromium.org, robertshield, mmenke, dyu1, Paweł Hajdan Jr., Avi (use Gerrit), darin-cc_chromium.org, Ilya Sherman, stuartmorgan+watch_chromium.org, dhollowa
Visibility:
Public.

Description

Cleanup: Remove forward declarations in various chrome/browser directories. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110225

Patch Set 1 : '' #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -67 lines) Patch
M chrome/browser/autofill/autofill_cc_infobar_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_download.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/autofill/autofill_feedback_infobar_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history.h View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/history/history_database.h View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/history/in_memory_history_backend.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/in_memory_url_index.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/history/top_sites_cache.h View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/history/top_sites_database.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/prerender/prerender_render_view_host_observer.h View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/prerender/prerender_tab_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_system_task_proxy.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/printing/print_view_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/printer_query.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_tab_restore_service_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_window.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/fullscreen_exit_bubble.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/omnibox/location_bar.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/search_engines/search_engine_tab_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/touch/tabs/touch_tab_strip.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/fullscreen_exit_bubble_views.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
9 years, 1 month ago (2011-11-15 19:42:53 UTC) #1
vandebo (ex-Chrome)
LGTM
9 years, 1 month ago (2011-11-15 21:56:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8533030/1013
9 years, 1 month ago (2011-11-15 23:12:28 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-16 00:52:46 UTC) #4 
Change committed as 110225

Powered by Google App Engine
This is Rietveld 408576698