Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 8533023: Add a content_resources target which currently includes the sandbox definitions on mac (Closed)

Created:
9 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
9 years, 1 month ago
Reviewers:
Dirk Pranke, Jói
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, pam+watch_chromium.org, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Add a content_resources target which currently includes the sandbox definitions on mac BUG=90443 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110115

Patch Set 1 #

Patch Set 2 : added missing file #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -1 line) Patch
M chrome/browser/browser_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/chrome_repack_chrome.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M content/content.gyp View 2 chunks +4 lines, -1 line 0 comments Download
A content/content_resources.grd View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A content/content_resources.gyp View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jochen (gone - plz use gerrit)
plz review
9 years, 1 month ago (2011-11-14 21:54:21 UTC) #1
Dirk Pranke
Why are you creating a new .gyp for this one target, rather than including it ...
9 years, 1 month ago (2011-11-14 22:00:56 UTC) #2
jochen (gone - plz use gerrit)
On 2011/11/14 22:00:56, Dirk Pranke wrote: > Why are you creating a new .gyp for ...
9 years, 1 month ago (2011-11-14 22:03:41 UTC) #3
Dirk Pranke
Ah. Ugh.
9 years, 1 month ago (2011-11-14 22:13:29 UTC) #4
Jói
> Because content.gyp depends on compositor.gyp which depends on > chrome_resources.gyp which would then depend ...
9 years, 1 month ago (2011-11-15 10:56:39 UTC) #5
jochen (gone - plz use gerrit)
all done
9 years, 1 month ago (2011-11-15 15:24:00 UTC) #6
Jói
lgtm
9 years, 1 month ago (2011-11-15 15:36:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/8533023/6001
9 years, 1 month ago (2011-11-15 16:48:37 UTC) #8
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 18:03:15 UTC) #9
Change committed as 110115

Powered by Google App Engine
This is Rietveld 408576698