Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: net/dns/async_host_resolver.cc

Issue 8533011: Remove unused HostResolver::Observer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove RequestInfo::referrer and Request::id Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/dns/async_host_resolver.cc
diff --git a/net/dns/async_host_resolver.cc b/net/dns/async_host_resolver.cc
index 70c9277c3975d929108e8d8f5a53056351e6a4e1..ae09917e21b8d8a02b718177ea7161000138b355 100644
--- a/net/dns/async_host_resolver.cc
+++ b/net/dns/async_host_resolver.cc
@@ -287,21 +287,10 @@ void AsyncHostResolver::OnStart(Request* request) {
NetLog::TYPE_ASYNC_HOST_RESOLVER_REQUEST,
make_scoped_refptr(new RequestParameters(
request->info(), request->source_net_log().source())));
-
- FOR_EACH_OBSERVER(
- HostResolver::Observer, observers_,
- OnStartResolution(request->id(), request->info()));
}
void AsyncHostResolver::OnFinish(Request* request, int result) {
DCHECK(request);
- bool was_resolved = result == OK;
-
- FOR_EACH_OBSERVER(
- HostResolver::Observer, observers_,
- OnFinishResolutionWithStatus(
- request->id(), was_resolved, request->info()));
-
request->request_net_log().EndEventWithNetErrorCode(
NetLog::TYPE_ASYNC_HOST_RESOLVER_REQUEST, result);
request->source_net_log().EndEvent(
@@ -311,10 +300,6 @@ void AsyncHostResolver::OnFinish(Request* request, int result) {
void AsyncHostResolver::OnCancel(Request* request) {
DCHECK(request);
- FOR_EACH_OBSERVER(
- HostResolver::Observer, observers_,
- OnCancelResolution(request->id(), request->info()));
-
request->request_net_log().AddEvent(
NetLog::TYPE_CANCELLED, NULL);
request->request_net_log().EndEvent(
@@ -334,14 +319,6 @@ void AsyncHostResolver::CancelRequest(RequestHandle req_handle) {
pending_requests_[request->priority()].remove(request.get());
}
-void AsyncHostResolver::AddObserver(HostResolver::Observer* observer) {
- observers_.AddObserver(observer);
-}
-
-void AsyncHostResolver::RemoveObserver(HostResolver::Observer* observer) {
- observers_.RemoveObserver(observer);
-}
-
void AsyncHostResolver::SetDefaultAddressFamily(
AddressFamily address_family) {
NOTIMPLEMENTED();

Powered by Google App Engine
This is Rietveld 408576698