Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: net/base/mock_host_resolver.h

Issue 8533011: Remove unused HostResolver::Observer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove id from AsyncHostResolver; add double-cancelation check; comments' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/mapped_host_resolver.cc ('k') | net/base/mock_host_resolver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/mock_host_resolver.h
diff --git a/net/base/mock_host_resolver.h b/net/base/mock_host_resolver.h
index 3c6f178220ae118ebced4da3fbc8720f7d62f530..145b8c067c8806d13fb77ae3f9374b2b268c58ca 100644
--- a/net/base/mock_host_resolver.h
+++ b/net/base/mock_host_resolver.h
@@ -10,7 +10,6 @@
#include <map>
#include "base/memory/weak_ptr.h"
-#include "base/observer_list.h"
#include "base/synchronization/waitable_event.h"
#include "base/threading/non_thread_safe.h"
#include "net/base/host_resolver.h"
@@ -63,9 +62,6 @@ class MockHostResolverBase : public HostResolver,
synchronous_mode_ = is_synchronous;
}
- // Resets the mock.
- void Reset(HostResolverProc* interceptor);
-
// HostResolver methods:
virtual int Resolve(const RequestInfo& info,
AddressList* addresses,
@@ -76,8 +72,6 @@ class MockHostResolverBase : public HostResolver,
AddressList* addresses,
const BoundNetLog& net_log) OVERRIDE;
virtual void CancelRequest(RequestHandle req) OVERRIDE;
- virtual void AddObserver(Observer* observer) OVERRIDE;
- virtual void RemoveObserver(Observer* observer) OVERRIDE;
virtual HostCache* GetHostCache() OVERRIDE;
protected:
@@ -97,7 +91,6 @@ class MockHostResolverBase : public HostResolver,
void ResolveNow(size_t id);
bool synchronous_mode_;
- ObserverList<Observer> observers_;
scoped_refptr<RuleBasedHostResolverProc> rules_;
scoped_refptr<HostResolverProc> proc_;
scoped_ptr<HostCache> cache_;
@@ -193,8 +186,6 @@ class HangingHostResolver : public HostResolver {
AddressList* addresses,
const BoundNetLog& net_log) OVERRIDE;
virtual void CancelRequest(RequestHandle req) OVERRIDE {}
- virtual void AddObserver(Observer* observer) OVERRIDE {}
- virtual void RemoveObserver(Observer* observer) OVERRIDE {}
};
// This class sets the default HostResolverProc for a particular scope. The
« no previous file with comments | « net/base/mapped_host_resolver.cc ('k') | net/base/mock_host_resolver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698