net/base/host_resolver_impl.h - Issue 8533011: Remove unused HostResolver::Observer.

Unified Diff: net/base/host_resolver_impl.h

Issue 8533011: Remove unused HostResolver::Observer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/host_resolver_impl.h

diff --git a/net/base/host_resolver_impl.h b/net/base/host_resolver_impl.h

index dd8cb4d47167ae40475f6453b4f7d0c58c216b58..b0211c214d69d8dd7f45a7e7b6a930408aa7ca56 100644

--- a/net/base/host_resolver_impl.h

+++ b/net/base/host_resolver_impl.h

@@ -136,8 +136,6 @@ class NET_EXPORT HostResolverImpl

AddressList* addresses,

const BoundNetLog& source_net_log) OVERRIDE;

virtual void CancelRequest(RequestHandle req) OVERRIDE;

- virtual void AddObserver(HostResolver::Observer* observer) OVERRIDE;

- virtual void RemoveObserver(HostResolver::Observer* observer) OVERRIDE;

virtual void SetDefaultAddressFamily(AddressFamily address_family) OVERRIDE;

virtual AddressFamily GetDefaultAddressFamily() const OVERRIDE;

virtual void ProbeIPv6Support() OVERRIDE;

@@ -157,7 +155,6 @@ class NET_EXPORT HostResolverImpl

typedef std::vector<Request*> RequestsList;

typedef HostCache::Key Key;

typedef std::map<Key, scoped_refptr<Job> > JobMap;

- typedef std::vector<HostResolver::Observer*> ObserversList;

// Helper used by |Resolve()| and |ResolveFromCache()|. Performs IP

// literal and cache lookup, returns OK if successful,

@@ -328,9 +325,6 @@ class NET_EXPORT HostResolverImpl

// HostResolver gets deleted from within the callback).

scoped_refptr<Job> cur_completing_job_;

- // The observers to notify when a request starts/ends.

- ObserversList observers_;

// Monotonically increasing ID number to assign to the next request.

// Observers are the only consumers of this ID number.

int next_request_id_;

eroman 2011/11/14 20:01:39 Can you delete this too? Or maybe it is still used

szym 2011/11/14 23:50:17 Currently HostResolverImpl does not use it, so I r

cbentzel 2011/11/15 10:49:01 You could always maintain a std::set<Request*> in

« no previous file with comments | « net/base/host_resolver.h ('k') | net/base/host_resolver_impl.cc » ('j') | no next file with comments »