Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: net/socket/transport_client_socket_pool.cc

Issue 8533011: Remove unused HostResolver::Observer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove RequestInfo::referrer and Request::id Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/socket/transport_client_socket_pool.h" 5 #include "net/socket/transport_client_socket_pool.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 const GURL& referrer, 64 const GURL& referrer,
65 bool disable_resolver_cache, 65 bool disable_resolver_cache,
66 bool ignore_limits) 66 bool ignore_limits)
67 : destination_(host_port_pair), ignore_limits_(ignore_limits) { 67 : destination_(host_port_pair), ignore_limits_(ignore_limits) {
68 Initialize(priority, referrer, disable_resolver_cache); 68 Initialize(priority, referrer, disable_resolver_cache);
69 } 69 }
70 70
71 TransportSocketParams::~TransportSocketParams() {} 71 TransportSocketParams::~TransportSocketParams() {}
72 72
73 void TransportSocketParams::Initialize(RequestPriority priority, 73 void TransportSocketParams::Initialize(RequestPriority priority,
74 const GURL& referrer, 74 const GURL& referrer,
eroman 2011/11/15 03:54:01 Please add a todo to remove |referrer| as it is no
75 bool disable_resolver_cache) { 75 bool disable_resolver_cache) {
76 // The referrer is used by the DNS prefetch system to correlate resolutions
77 // with the page that triggered them. It doesn't impact the actual addresses
78 // that we resolve to.
79 destination_.set_referrer(referrer);
80 destination_.set_priority(priority); 76 destination_.set_priority(priority);
81 if (disable_resolver_cache) 77 if (disable_resolver_cache)
82 destination_.set_allow_cached_response(false); 78 destination_.set_allow_cached_response(false);
83 } 79 }
84 80
85 // TransportConnectJobs will time out after this many seconds. Note this is 81 // TransportConnectJobs will time out after this many seconds. Note this is
86 // the total time, including both host resolution and TCP connect() times. 82 // the total time, including both host resolution and TCP connect() times.
87 // 83 //
88 // TODO(eroman): The use of this constant needs to be re-evaluated. The time 84 // TODO(eroman): The use of this constant needs to be re-evaluated. The time
89 // needed for TCPClientSocketXXX::Connect() can be arbitrarily long, since 85 // needed for TCPClientSocketXXX::Connect() can be arbitrarily long, since
(...skipping 391 matching lines...) Expand 10 before | Expand all | Expand 10 after
481 477
482 base::TimeDelta TransportClientSocketPool::ConnectionTimeout() const { 478 base::TimeDelta TransportClientSocketPool::ConnectionTimeout() const {
483 return base_.ConnectionTimeout(); 479 return base_.ConnectionTimeout();
484 } 480 }
485 481
486 ClientSocketPoolHistograms* TransportClientSocketPool::histograms() const { 482 ClientSocketPoolHistograms* TransportClientSocketPool::histograms() const {
487 return base_.histograms(); 483 return base_.histograms();
488 } 484 }
489 485
490 } // namespace net 486 } // namespace net
OLDNEW
« net/socket/socks_client_socket_pool.cc ('K') | « net/socket/socks_client_socket_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698