Remove unused HostResolver::Observer.

net/dns/async_host_resolver.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/async_host_resolver.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 269 matching lines @@
   DCHECK(request);
 
   request->source_net_log().BeginEvent(
       NetLog::TYPE_ASYNC_HOST_RESOLVER,
       make_scoped_refptr(new NetLogSourceParameter(
           "source_dependency", request->request_net_log().source())));
   request->request_net_log().BeginEvent(
       NetLog::TYPE_ASYNC_HOST_RESOLVER_REQUEST,
       make_scoped_refptr(new RequestParameters(
           request->info(), request->source_net_log().source())));
-
-  FOR_EACH_OBSERVER(
-      HostResolver::Observer, observers_,
-      OnStartResolution(request->id(), request->info()));
 }
 
 void AsyncHostResolver::OnFinish(Request* request, int result) {
   DCHECK(request);
-  bool was_resolved = result == OK;
-
-  FOR_EACH_OBSERVER(
-      HostResolver::Observer, observers_,
-      OnFinishResolutionWithStatus(
-          request->id(), was_resolved, request->info()));
-
   request->request_net_log().EndEventWithNetErrorCode(
       NetLog::TYPE_ASYNC_HOST_RESOLVER_REQUEST, result);
   request->source_net_log().EndEvent(
       NetLog::TYPE_ASYNC_HOST_RESOLVER, NULL);
 }
 
 void AsyncHostResolver::OnCancel(Request* request) {
   DCHECK(request);
 
-  FOR_EACH_OBSERVER(
-      HostResolver::Observer, observers_,
-      OnCancelResolution(request->id(), request->info()));
-
   request->request_net_log().AddEvent(
       NetLog::TYPE_CANCELLED, NULL);
   request->request_net_log().EndEvent(
       NetLog::TYPE_ASYNC_HOST_RESOLVER_REQUEST, NULL);
   request->source_net_log().EndEvent(
       NetLog::TYPE_ASYNC_HOST_RESOLVER, NULL);
 }
 
 void AsyncHostResolver::CancelRequest(RequestHandle req_handle) {
   scoped_ptr<Request> request(reinterpret_cast<Request*>(req_handle));
   DCHECK(request.get());
 
   KeyRequestListMap::iterator it = requestlist_map_.find(request->key());
   if (it != requestlist_map_.end())
     it->second.remove(request.get());
   else
     pending_requests_[request->priority()].remove(request.get());
 }
 
-void AsyncHostResolver::AddObserver(HostResolver::Observer* observer) {
-  observers_.AddObserver(observer);
-}
-
-void AsyncHostResolver::RemoveObserver(HostResolver::Observer* observer) {
-  observers_.RemoveObserver(observer);
-}
-
 void AsyncHostResolver::SetDefaultAddressFamily(
     AddressFamily address_family) {
   NOTIMPLEMENTED();
 }
 
 AddressFamily AsyncHostResolver::GetDefaultAddressFamily() const {
   return ADDRESS_FAMILY_IPV4;
 }
 
 HostCache* AsyncHostResolver::GetHostCache() {
@@ skipping 53 matching lines @@
   ProcessPending();
 }
 
 AsyncHostResolver::Request* AsyncHostResolver::CreateNewRequest(
     const RequestInfo& info,
     OldCompletionCallback* callback,
     AddressList* addresses,
     const BoundNetLog& source_net_log) {
   BoundNetLog request_net_log = BoundNetLog::Make(net_log_,
       NetLog::SOURCE_ASYNC_HOST_RESOLVER_REQUEST);
   int id = next_request_id_++;

[cbentzel, 2011/11/15 10:49:01]

Could you remove id here, and from Request?

   return new Request(
       this, source_net_log, request_net_log, id, info, callback, addresses);
 }
 
 bool AsyncHostResolver::AttachToRequestList(Request* request) {
   KeyRequestListMap::iterator it = requestlist_map_.find(request->key());
   if (it == requestlist_map_.end())
     return false;
   it->second.push_back(request);
   return true;
@@ skipping 87 matching lines @@
         it = requests.erase(it);
       } else {
         ++it;
       }
     }
   }
   StartNewTransactionFor(request);
 }
 
 }  // namespace net