Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

Issue 8533007: Mark WebUIBidiCheckerBrowserTest.TestDownloadsPageLTR flaky on Win and Linux. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/bidi_checker_web_ui_test.h" 5 #include "chrome/browser/ui/webui/bidi_checker_web_ui_test.h"
6 6
7 #include "base/base_paths.h" 7 #include "base/base_paths.h"
8 #include "base/i18n/rtl.h" 8 #include "base/i18n/rtl.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTest, TestCrashesPageLTR) { 128 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTest, TestCrashesPageLTR) {
129 RunBidiCheckerOnPage(chrome::kChromeUICrashesURL, false); 129 RunBidiCheckerOnPage(chrome::kChromeUICrashesURL, false);
130 } 130 }
131 131
132 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestFakeBidi, 132 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestFakeBidi,
133 TestCrashesPageRTL) { 133 TestCrashesPageRTL) {
134 WebUIBidiCheckerBrowserTest::RunBidiCheckerOnPage(chrome::kChromeUICrashesURL, 134 WebUIBidiCheckerBrowserTest::RunBidiCheckerOnPage(chrome::kChromeUICrashesURL,
135 true); 135 true);
136 } 136 }
137 137
138 #if defined(OS_WIN) || defined(OS_LINUX)
139 // http://crbug.com/104129
140 #define TestDownloadsPageLTR FLAKY_TestDownloadsPageLTR
141 #endif
138 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTest, TestDownloadsPageLTR) { 142 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTest, TestDownloadsPageLTR) {
139 RunBidiCheckerOnPage(chrome::kChromeUIDownloadsURL, false); 143 RunBidiCheckerOnPage(chrome::kChromeUIDownloadsURL, false);
140 } 144 }
141 145
142 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestFakeBidi, 146 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestFakeBidi,
143 TestDownloadsPageRTL) { 147 TestDownloadsPageRTL) {
144 WebUIBidiCheckerBrowserTest::RunBidiCheckerOnPage( 148 WebUIBidiCheckerBrowserTest::RunBidiCheckerOnPage(
145 chrome::kChromeUIDownloadsURL, true); 149 chrome::kChromeUIDownloadsURL, true);
146 } 150 }
147 151
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 "5125551234"); 243 "5125551234");
240 244
241 PersonalDataManager* personal_data_manager = 245 PersonalDataManager* personal_data_manager =
242 PersonalDataManagerFactory::GetForProfile(browser()->profile()); 246 PersonalDataManagerFactory::GetForProfile(browser()->profile());
243 ASSERT_TRUE(personal_data_manager); 247 ASSERT_TRUE(personal_data_manager);
244 248
245 personal_data_manager->AddProfile(profile); 249 personal_data_manager->AddProfile(profile);
246 250
247 WebUIBidiCheckerBrowserTest::RunBidiCheckerOnPage(url.c_str(), true); 251 WebUIBidiCheckerBrowserTest::RunBidiCheckerOnPage(url.c_str(), true);
248 } 252 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698