Better handling of stdin/stdout/stderr

runtime/bin/eventhandler_linux.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <errno.h>
 #include <poll.h>
 #include <pthread.h>
 #include <stdio.h>
 #include <string.h>
 #include <sys/time.h>
@@ skipping 225 matching lines @@
     // Prioritize data events over close and error events.
     if ((pollfd->revents & POLLIN) != 0) {
       if (FDUtils::AvailableBytes(pollfd->fd) != 0) {
         event_mask = (1 << kInEvent);
       } else if (((pollfd->revents & POLLHUP) != 0)) {
         event_mask = (1 << kCloseEvent);
         sd->MarkClosedRead();
       } else if ((pollfd->revents & POLLERR) != 0) {
         event_mask = (1 << kErrorEvent);
       } else {
-        // If POLLIN is set with no available data and no POLLHUP use
-        // recv to peek for whether the other end of the socket
-        // actually closed.
-        char buffer;
-        ssize_t bytesPeeked = recv(sd->fd(), &buffer, 1, MSG_PEEK);
-        if (bytesPeeked == 0) {
-          event_mask = (1 << kCloseEvent);
-          sd->MarkClosedRead();
-        } else if (errno != EAGAIN) {
-          fprintf(stderr, "Error recv: %s\n", strerror(errno));
+        if (sd->IsPipe()) {
+          // For stdin when reading from a terminal treat POLLIN with 0
+          // available bytes as end-of-file.
+          if (sd->fd() == STDIN_FILENO && isatty(sd->fd())) {
+            event_mask = (1 << kCloseEvent);
+            sd->MarkClosedRead();
+          }
+        } else {
+          // If POLLIN is set with no available data and no POLLHUP use
+          // recv to peek for whether the other end of the socket
+          // actually closed.
+          char buffer;
+          ssize_t bytesPeeked = recv(sd->fd(), &buffer, 1, MSG_PEEK);
+          if (bytesPeeked == 0) {
+            event_mask = (1 << kCloseEvent);
+            sd->MarkClosedRead();
+          } else if (errno != EAGAIN) {
+            fprintf(stderr, "Error recv: %s\n", strerror(errno));
+          }
         }
       }
     }
 
     // On pipes POLLHUP is reported without POLLIN.
-    if (((pollfd->revents & POLLIN) == 0) &&
-        ((pollfd->revents & POLLHUP) != 0)) {
-      event_mask = (1 << kCloseEvent);
-      sd->MarkClosedRead();
+    if (sd->IsPipe()) {
+      if (((pollfd->revents & POLLIN) == 0) &&
+          ((pollfd->revents & POLLHUP) != 0)) {
+        event_mask = (1 << kCloseEvent);
+        sd->MarkClosedRead();
+      }
     }
 
     if ((pollfd->revents & POLLOUT) != 0) event_mask |= (1 << kOutEvent);
   }
 
   return event_mask;
 }
 
 
 void EventHandlerImplementation::HandleEvents(struct pollfd* pollfds,
@@ skipping 75 matching lines @@
     FATAL("Create start event handler thread");
   }
 }
 
 
 void EventHandlerImplementation::SendData(intptr_t id,
                                           Dart_Port dart_port,
                                           intptr_t data) {
   WakeupHandler(id, dart_port, data);
 }