Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 8532001: Notify the widget delegate when the aura window moves (Closed)

Created:
9 years, 1 month ago by DaveMoore
Modified:
9 years, 1 month ago
CC:
chromium-reviews, tfarina, dhollowa
Visibility:
Public.

Description

Notify the widget delegate when the aura window moves BUG=103831 TEST=Move window after typing text in omnibox Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109646

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M views/widget/native_widget_aura.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
DaveMoore
9 years, 1 month ago (2011-11-10 23:29:58 UTC) #1
Ben Goodger (Google)
9 years, 1 month ago (2011-11-11 04:06:24 UTC) #2
LGTM

On Thu, Nov 10, 2011 at 3:29 PM, <davemoore@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Notify the widget delegate when the aura window moves
>
>
> BUG=103831
> TEST=Move window after typing text in omnibox
>
>
> Please review this at
http://codereview.chromium.**org/8532001/<http://codereview.chromium.org/8532...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M views/widget/native_widget_**aura.cc
>
>
> Index: views/widget/native_widget_**aura.cc
> diff --git a/views/widget/native_widget_**aura.cc
> b/views/widget/native_widget_**aura.cc
> index 8da5452a3bda5237fb9ef22eab9ea9**2d92fbd19f..**
> edf5510f1566768c4a183937eedf94**4e099c74b8 100644
> --- a/views/widget/native_widget_**aura.cc
> +++ b/views/widget/native_widget_**aura.cc
> @@ -521,6 +521,8 @@ void NativeWidgetAura::**DispatchKeyEventPostIME(const
> KeyEvent& key) {
>
>  void NativeWidgetAura::**OnBoundsChanged(const gfx::Rect& old_bounds,
>                                        const gfx::Rect& new_bounds) {
> +  if (old_bounds.origin() != new_bounds.origin())
> +    GetWidget()->widget_delegate()**->OnWidgetMove();
>   if (old_bounds.size() != new_bounds.size())
>     delegate_->**OnNativeWidgetSizeChanged(new_**bounds.size());
>  }
>
>
>

Powered by Google App Engine
This is Rietveld 408576698