Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 8531002: new webkit_browsertest for crbug.com/103058 (Closed)

Created:
9 years, 1 month ago by gavinp
Modified:
9 years, 1 month ago
Reviewers:
Nate Chapin, jam
CC:
chromium-reviews, tfarina, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

new webkit_browsertest for crbug.com/103058 Unfortunately, I haven't been able to reproduce bug 103058 very well in WebKit's LayoutTest engine, because DumpRenderTree's libraries interfere with resource lifetime; a browser_test doesn't have this issue, so it's able to act as a good regression test for this issue. BUG=103058 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110321

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
A chrome/test/data/webkit/resources/xslt-bad-import-uri.xml View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/test/data/webkit/resources/xslt-bad-import-uri.xsl View 1 chunk +7 lines, -0 lines 0 comments Download
A chrome/test/data/webkit/xslt-bad-import.html View 1 chunk +14 lines, -0 lines 0 comments Download
M content/browser/webkit_browsertest.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
gavinp
See also https://bugs.webkit.org/show_bug.cgi?id=72068 , which is the WebKit fix that this tests.
9 years, 1 month ago (2011-11-11 00:00:47 UTC) #1
jam
i defer to others on this as before. rubberstamp lgtm for content
9 years, 1 month ago (2011-11-11 02:57:59 UTC) #2
Nate Chapin
On 2011/11/11 02:57:59, John Abd-El-Malek wrote: > i defer to others on this as before. ...
9 years, 1 month ago (2011-11-14 23:38:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/8531002/1
9 years, 1 month ago (2011-11-15 15:07:17 UTC) #4
commit-bot: I haz the power
Try job failure for 8531002-1 (retry) on win_rel for step "safe_browsing_tests" (clobber build). It's a ...
9 years, 1 month ago (2011-11-15 16:43:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/8531002/1
9 years, 1 month ago (2011-11-15 21:57:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/8531002/1
9 years, 1 month ago (2011-11-16 16:33:47 UTC) #7
commit-bot: I haz the power
9 years, 1 month ago (2011-11-16 17:54:54 UTC) #8
Change committed as 110321

Powered by Google App Engine
This is Rietveld 408576698