Issue 853004: Compute reaching definitions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 853004: Compute reaching definitions. (Closed)

Created:
10 years, 9 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Visibility:
Public.

Description

Compute reaching definitions. Use the classical worklist algorithm to compute reaching definitions. All nodes are initially put on the worklist. Until the worklist is empty, nodes are removed, their RD_in is recomputed, and if it changes their successors are added to the worklist. Committed: http://code.google.com/p/v8/source/detail?r=4113

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix worklist bug. #

Patch Set 3 : Leave entry node off the worklist. #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+208 lines, -9 lines)			Patch
	M	src/data-flow.h	View		7 chunks	+71 lines, -3 lines	0 comments	Download
	M	src/data-flow.cc	View	1 2	4 chunks	+137 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

Marking bug fixed, please take a look.

10 years, 9 months ago (2010-03-12 09:56:26 UTC) #2

fschneider

10 years, 9 months ago (2010-03-12 10:25:20 UTC) #3

LGTM.

http://codereview.chromium.org/853004/diff/1/2
File src/data-flow.cc (right):

http://codereview.chromium.org/853004/diff/1/2#newcode1982
src/data-flow.cc:1982: BitVector temp(definition_count);
I don't know if it's worth doing, but since ComputeRDOut always overwrites all
elements in the BitVector temp, you could reuse one instance for the loop.

http://codereview.chromium.org/853004/diff/1/2#newcode2025
src/data-flow.cc:2025: BitVector temp(definition_count);
Also could reuse one BitVector temp here.

Expand Messages | Collapse Messages