Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1623)

Issue 8530006: chromeos: Add a missing RemoveObserver call in TestingAutomationProvider. (Closed)

Created:
9 years, 1 month ago by satorux1
Modified:
9 years, 1 month ago
Reviewers:
tbarzic
CC:
chromium-reviews, robertshield, kkania, Paweł Hajdan Jr.
Visibility:
Public.

Description

chromeos: Add a missing RemoveObserver call in TestingAutomationProvider. Otherwise, TestingAutomationPrivider may be referenced after it's deleted. TEST=linux_chromeos try job BUG=104029 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109815

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
9 years, 1 month ago (2011-11-12 22:08:44 UTC) #1
tbarzic
On 2011/11/12 22:08:44, satorux1 wrote: LGTM
9 years, 1 month ago (2011-11-12 22:10:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/8530006/1
9 years, 1 month ago (2011-11-13 00:52:39 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-13 02:05:34 UTC) #4
Change committed as 109815

Powered by Google App Engine
This is Rietveld 408576698