Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9999)

Unified Diff: chrome/renderer/resources/extensions/extension_process_bindings.js

Issue 8530003: Delete the temporary file when generating MHTML with the extension API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Clean-up Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/extension_process_bindings.js
diff --git a/chrome/renderer/resources/extensions/extension_process_bindings.js b/chrome/renderer/resources/extensions/extension_process_bindings.js
index 96db3680440ac2be55915a2ea65468198c0fe7c2..18ab836a44cd20a22cb5951a414660b8d77d71a1 100644
--- a/chrome/renderer/resources/extensions/extension_process_bindings.js
+++ b/chrome/renderer/resources/extensions/extension_process_bindings.js
@@ -24,6 +24,7 @@ var chrome = chrome || {};
native function GetLocalFileSystem(name, path);
native function DecodeJPEG(jpegImage);
native function CreateBlob(filePath);
+ native function SendResponseAck(requestId);
var chromeHidden = GetChromeHidden();
@@ -178,6 +179,7 @@ var chrome = chrome || {};
var nativeFunction = opt_args.nativeFunction || StartRequest;
var requestId = GetNextRequestId();
+ request.id = requestId;
requests[requestId] = request;
var hasCallback =
(request.callback || opt_args.customCallback) ? true : false;
@@ -766,8 +768,11 @@ var chrome = chrome || {};
if (request.callback)
request.callback(CreateBlob(path, size));
-
request.callback = null;
+
+ // Notify the browser. Now that the blob is referenced from JavaScript,
+ // the browser can drop its reference to it.
+ SendResponseAck(request.id);
};
apiFunctions["fileBrowserPrivate.requestLocalFileSystem"].customCallback =

Powered by Google App Engine
This is Rietveld 408576698