Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 8530002: Convert comments in ppb_flash.h to the standard format. (Closed)

Created:
9 years, 1 month ago by viettrungluu
Modified:
9 years, 1 month ago
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Convert comments in ppb_flash.h to the standard format. This will make reviewing the next change, to actually generate ppb_flash.h from ppb_flash.idl, less painful. TBR=noelallen@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109786

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -28 lines) Patch
M ppapi/c/private/ppb_flash.h View 1 3 chunks +53 lines, -28 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
TBRing, since it's a comment-only change.
9 years, 1 month ago (2011-11-12 05:13:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/8530002/1
9 years, 1 month ago (2011-11-12 05:14:03 UTC) #2
commit-bot: I haz the power
Presubmit check for 8530002-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 1 month ago (2011-11-12 05:14:11 UTC) #3
noelallen_use_chromium
Your comment style is wrong, so you'll still see a diff. :) http://codereview.chromium.org/8530002/diff/1/ppapi/c/private/ppb_flash.h File ppapi/c/private/ppb_flash.h ...
9 years, 1 month ago (2011-11-12 05:43:30 UTC) #4
viettrungluu
9 years, 1 month ago (2011-11-12 06:53:02 UTC) #5
thanks

http://codereview.chromium.org/8530002/diff/1/ppapi/c/private/ppb_flash.h
File ppapi/c/private/ppb_flash.h (right):

http://codereview.chromium.org/8530002/diff/1/ppapi/c/private/ppb_flash.h#new...
ppapi/c/private/ppb_flash.h:30: struct PPB_Flash {
On 2011/11/12 05:43:30, noelallen wrote:
> Should be:
> struct PPB_Flash {
>   /**
>    * Sets or clears....

Done.

Powered by Google App Engine
This is Rietveld 408576698