chrome/browser/extensions/extension_service.h - Issue 8529001: Fix crash in ExtensionService::SetIsIncognitoEnabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 8529001: Fix crash in ExtensionService::SetIsIncognitoEnabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_service.h

diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h

index 0a1ec62a405f8c548f0ad0361923e2da18ec3095..675b54e17ca7e9b6f2a709e152ec2741890bb5ad 100644

--- a/chrome/browser/extensions/extension_service.h

+++ b/chrome/browser/extensions/extension_service.h

@@ -191,8 +191,7 @@ class ExtensionService

// Whether this extension can run in an incognito window.

virtual bool IsIncognitoEnabled(const std::string& extension_id) const;

- virtual void SetIsIncognitoEnabled(const std::string& extension_id,

- bool enabled);

+ virtual void SetIsIncognitoEnabled(std::string extension_id, bool enabled);

Finnur 2011/11/10 21:48:44 This is virtual, don't you need to change signatur

virtual void SetAppNotificationSetupDone(const std::string& extension_id,

bool value);