Fix crash in ExtensionService::SetIsIncognitoEnabled.

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 1438 matching lines @@
   // work in incognito mode.
   const Extension* extension = GetInstalledExtension(extension_id);
   if (extension && extension->location() == Extension::COMPONENT)
     return true;
 
   // Check the prefs.
   return extension_prefs_->IsIncognitoEnabled(extension_id);
 }
 
 void ExtensionService::SetIsIncognitoEnabled(
-    const std::string& extension_id, bool enabled) {
+    std::string extension_id, bool enabled) {

[Finnur, 2011/11/10 21:48:44]

I wonder if people will be tempted to change this back to const ref, since it
isn't obvious that a copy is needed and therefore people would look at this as a
potential speedup opportunity? 

Should we document that this must be a copy because callers will likely not make
a copy of the value before calling us?

Or should we take a const ref, but make a copy ourselves (line 1478) before we
reload?

Or should we have the only caller (in this file at least -- are there others?)
make a copy of the ID as well, since we already cache some extension data (line
1409).

Just a thought.

   const Extension* extension = GetInstalledExtension(extension_id);
   if (extension && extension->location() == Extension::COMPONENT) {
     // This shouldn't be called for component extensions.
     NOTREACHED();
     return;
   }
 
   // Broadcast unloaded and loaded events to update browser state. Only bother
   // if the value changed and the extension is actually enabled, since there is
   // no UI otherwise.
@@ skipping 1020 matching lines @@
 
 ExtensionService::NaClModuleInfoList::iterator
     ExtensionService::FindNaClModule(const GURL& url) {
   for (NaClModuleInfoList::iterator iter = nacl_module_list_.begin();
        iter != nacl_module_list_.end(); ++iter) {
     if (iter->url == url)
       return iter;
   }
   return nacl_module_list_.end();
 }