Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: chrome/common/extensions/extension_constants.h

Issue 8528054: Sync Promo: Add more UMA metrics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more code review changes Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/sync_promo_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_constants.h
diff --git a/chrome/common/extensions/extension_constants.h b/chrome/common/extensions/extension_constants.h
index 27febbe79bc9b52c688b14acb114d90374040204..1f47f8f6ae52ec6d12a7f94190fe1b3a09de8b9a 100644
--- a/chrome/common/extensions/extension_constants.h
+++ b/chrome/common/extensions/extension_constants.h
@@ -453,26 +453,6 @@ namespace extension_misc {
UNLOAD_REASON_UNINSTALL, // Extension is being uninstalled.
UNLOAD_REASON_TERMINATE, // Extension has terminated.
};
-
- // User actions on the sync promo (aka "Sign in to Chrome").
- enum SyncPromoBuckets {
- SYNC_PROMO_VIEWED,
- SYNC_PROMO_LEARN_MORE_CLICKED,
- SYNC_PROMO_ACCOUNT_HELP_CLICKED,
- SYNC_PROMO_CREATE_ACCOUNT_CLICKED,
- SYNC_PROMO_SKIP_CLICKED,
- SYNC_PROMO_SIGN_IN_ATTEMPTED,
- SYNC_PROMO_SIGNED_IN_SUCCESSFULLY,
- SYNC_PROMO_ADVANCED_CLICKED,
- SYNC_PROMO_ENCRYPTION_HELP_CLICKED,
- SYNC_PROMO_CANCELLED_AFTER_SIGN_IN,
- SYNC_PROMO_CONFIRMED_AFTER_SIGN_IN,
- SYNC_PROMO_CLOSED_TAB,
- SYNC_PROMO_CLOSED_WINDOW,
- SYNC_PROMO_BUCKET_BOUNDARY,
- SYNC_PROMO_FIRST_VALID_JS_ACTION = SYNC_PROMO_LEARN_MORE_CLICKED,
- SYNC_PROMO_LAST_VALID_JS_ACTION = SYNC_PROMO_CONFIRMED_AFTER_SIGN_IN,
- };
-} // extension_misc
+} // extension_misc
#endif // CHROME_COMMON_EXTENSIONS_EXTENSION_CONSTANTS_H_
« no previous file with comments | « chrome/browser/ui/webui/sync_promo_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698