Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2098)

Unified Diff: chrome/browser/ui/webui/sync_promo_handler.h

Issue 8528054: Sync Promo: Add more UMA metrics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more code review changes Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/metrics_handler.h ('k') | chrome/browser/ui/webui/sync_promo_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/sync_promo_handler.h
diff --git a/chrome/browser/ui/webui/sync_promo_handler.h b/chrome/browser/ui/webui/sync_promo_handler.h
index fa792858779aaeb4578d0f59dc7a179100be41e2..dbd5f1dbd891ae1a6d3603c5afd7b948741b27b6 100644
--- a/chrome/browser/ui/webui/sync_promo_handler.h
+++ b/chrome/browser/ui/webui/sync_promo_handler.h
@@ -10,7 +10,7 @@
class PrefService;
-// The handler for Javascript messages related to the "sync promo" page.
+// The handler for JavaScript messages related to the "sync promo" page.
class SyncPromoHandler : public SyncSetupHandler {
public:
explicit SyncPromoHandler(ProfileManager* profile_manager);
@@ -36,19 +36,30 @@ class SyncPromoHandler : public SyncSetupHandler {
virtual void ShowSetupUI() OVERRIDE;
private:
- // Javascript callback handler to close the sync promo.
+ // JavaScript callback handler to close the sync promo.
void HandleCloseSyncPromo(const base::ListValue* args);
- // Javascript callback handler to initialize the sync promo.
+ // JavaScript callback handler to initialize the sync promo.
void HandleInitializeSyncPromo(const base::ListValue* args);
- // Javascript callback handler to switch the advanced sync settings. |args| is
+ // JavaScript handler to record the duration for which the throbber was
+ // visible during an attempted sign-in flow.
+ void HandleRecordThrobberTime(const base::ListValue* args);
+
+ // JavaScript handler to record the number of times a user attempted to sign
+ // in to chrome while they were on the sync promo page.
+ void HandleRecordSignInAttempts(const base::ListValue* args);
+
+ // JavaScript callback handler to switch the advanced sync settings. |args| is
// the list of arguments passed from JS and should be an empty list.
void HandleShowAdvancedSettings(const base::ListValue* args);
- // Javascript callback handler to record user actions on the sync promo.
+ // JavaScript callback handler to record user actions on the sync promo.
void HandleUserFlowAction(const base::ListValue* args);
+ // JavaScript callback handler for when a user clicks skip.
+ void HandleUserSkipped(const base::ListValue* args);
+
// Return the number of times the user with the current profile has seen the
// sync promo.
int GetViewCount() const;
« no previous file with comments | « chrome/browser/ui/webui/metrics_handler.h ('k') | chrome/browser/ui/webui/sync_promo_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698