Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: chrome/browser/resources/sync_setup_overlay.js

Issue 8528054: Sync Promo: Add more UMA metrics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more code review changes Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/sync_promo.js ('k') | chrome/browser/ui/webui/metrics_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/sync_setup_overlay.js
diff --git a/chrome/browser/resources/sync_setup_overlay.js b/chrome/browser/resources/sync_setup_overlay.js
index 5b1474a68848d18a7664e5d804ba505598d99970..a972b26549b20b6256d79ff5818826a6be411ce6 100644
--- a/chrome/browser/resources/sync_setup_overlay.js
+++ b/chrome/browser/resources/sync_setup_overlay.js
@@ -538,10 +538,15 @@ cr.define('options', function() {
this.showOverlay_();
},
+ /**
+ * Changes the visibility of throbbers on this page.
+ * @param {boolean} visible Whether or not to set all throbber nodes
+ * visible.
+ */
setThrobbersVisible_: function(visible) {
var throbbers = document.getElementsByClassName("throbber");
- for (var i = 0; i < throbbers.length; i++)
- throbbers[i].style.visibility = visible ? "visible" : "hidden";
+ for (var i = 0; i < throbbers.length; i++)
+ throbbers[i].style.visibility = visible ? "visible" : "hidden";
},
loginSetFocus_: function() {
@@ -771,7 +776,7 @@ cr.define('options', function() {
$('captcha-value').disabled = true;
$('access-code').disabled = true;
- $('logging-in-throbber').style.visibility = "visible";
+ this.setThrobbersVisible_(true);
var f = $('gaia-login-form');
var email = $('gaia-email');
« no previous file with comments | « chrome/browser/resources/sync_promo.js ('k') | chrome/browser/ui/webui/metrics_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698