Chromium Code Reviews| Index: chrome/common/extensions/extension_constants.h |
| diff --git a/chrome/common/extensions/extension_constants.h b/chrome/common/extensions/extension_constants.h |
| index 27febbe79bc9b52c688b14acb114d90374040204..d75c46b174f836ac89f186513734b883d1425781 100644 |
| --- a/chrome/common/extensions/extension_constants.h |
| +++ b/chrome/common/extensions/extension_constants.h |
| @@ -454,6 +454,7 @@ namespace extension_misc { |
| UNLOAD_REASON_TERMINATE, // Extension has terminated. |
| }; |
| + // TODO(dbeam): Is this the right place for these values? |
|
Evan Stade
2011/11/15 17:45:19
nope
Dan Beam
2011/11/15 18:37:13
Done. (moved to sync_promo_handler.h)
Dan Beam
2011/11/15 18:38:05
Sorry, sync_promo_handler.cc rather.
|
| // User actions on the sync promo (aka "Sign in to Chrome"). |
| enum SyncPromoBuckets { |
| SYNC_PROMO_VIEWED, |
| @@ -469,6 +470,7 @@ namespace extension_misc { |
| SYNC_PROMO_CONFIRMED_AFTER_SIGN_IN, |
| SYNC_PROMO_CLOSED_TAB, |
| SYNC_PROMO_CLOSED_WINDOW, |
| + SYNC_PROMO_LEFT_DURING_THROBBER, |
| SYNC_PROMO_BUCKET_BOUNDARY, |
| SYNC_PROMO_FIRST_VALID_JS_ACTION = SYNC_PROMO_LEARN_MORE_CLICKED, |
| SYNC_PROMO_LAST_VALID_JS_ACTION = SYNC_PROMO_CONFIRMED_AFTER_SIGN_IN, |