Sync Promo: Add more UMA metrics.

chrome/browser/ui/webui/sync_promo_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/sync_promo_handler.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/metrics/histogram.h"
+#include "base/time.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/browser/sync/sync_setup_flow.h"
 #include "chrome/browser/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/webui/sync_promo_ui.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "content/browser/tab_contents/tab_contents.h"
+#include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_service.h"
-#include "content/public/browser/notification_details.h"
+
+namespace {
+
+// This was added because of the need to change the existing UMA enum for the
+// sync promo mid-flight. Ideally these values would be contiguous, but the
+// real world is not always ideal.
+static bool IsValidUserFlowAction(int action) {
+  return (action >= extension_misc::SYNC_PROMO_FIRST_VALID_JS_ACTION &&
+          action <= extension_misc::SYNC_PROMO_LAST_VALID_JS_ACTION) ||
+         action == extension_misc::SYNC_PROMO_LEFT_DURING_THROBBER;
+}
+
+}  // namespace
 
 SyncPromoHandler::SyncPromoHandler(ProfileManager* profile_manager)
     : SyncSetupHandler(profile_manager),
       window_already_closed_(false) {
 }
 
 SyncPromoHandler::~SyncPromoHandler() {
 }
 
 // static
@@ skipping 25 matching lines @@
   return SyncSetupHandler::Attach(web_ui);
 }
 
 void SyncPromoHandler::RegisterMessages() {
   web_ui_->RegisterMessageCallback("SyncPromo:Close",
       base::Bind(&SyncPromoHandler::HandleCloseSyncPromo,
                  base::Unretained(this)));
   web_ui_->RegisterMessageCallback("SyncPromo:Initialize",
       base::Bind(&SyncPromoHandler::HandleInitializeSyncPromo,
                  base::Unretained(this)));
+  web_ui_->RegisterMessageCallback("SyncPromo:RecordSignInAttempts",
+      base::Bind(&SyncPromoHandler::HandleRecordSignInAttempts,
+                 base::Unretained(this)));
+  web_ui_->RegisterMessageCallback("SyncPromo:RecordThrobberTime",
+      base::Bind(&SyncPromoHandler::HandleRecordThrobberTime,
+                 base::Unretained(this)));
+  web_ui_->RegisterMessageCallback("SyncPromo:ShowAdvancedSettings",
+      base::Bind(&SyncPromoHandler::HandleShowAdvancedSettings,
+                 base::Unretained(this)));
   web_ui_->RegisterMessageCallback("SyncPromo:UserFlowAction",
       base::Bind(&SyncPromoHandler::HandleUserFlowAction,
                  base::Unretained(this)));
-  web_ui_->RegisterMessageCallback("SyncPromo:ShowAdvancedSettings",
-      base::Bind(&SyncPromoHandler::HandleShowAdvancedSettings,
-                 base::Unretained(this)));
   SyncSetupHandler::RegisterMessages();
 }
 
 void SyncPromoHandler::ShowConfigure(const base::DictionaryValue& args) {
   bool usePassphrase = false;
   args.GetBoolean("usePassphrase", &usePassphrase);
 
   if (usePassphrase) {
     // If a passphrase is required then we must show the configure pane.
     SyncSetupHandler::ShowConfigure(args);
@@ skipping 75 matching lines @@
 void SyncPromoHandler::HandleShowAdvancedSettings(
     const base::ListValue* args) {
   CloseSyncSetup();
   std::string url(chrome::kChromeUISettingsURL);
   url += chrome::kSyncSetupSubPage;
   web_ui_->tab_contents()->OpenURL(GURL(url), GURL(), CURRENT_TAB,
                                    content::PAGE_TRANSITION_LINK);
   RecordUserFlowAction(extension_misc::SYNC_PROMO_ADVANCED_CLICKED);
 }
 
+// TODO(dbeam): Replace with metricsHandler:recordHistogramTime when it exists.
+void SyncPromoHandler::HandleRecordThrobberTime(const base::ListValue* args) {
+  double time_double;
+  CHECK(args->GetDouble(0, &time_double));
+  UMA_HISTOGRAM_TIMES("SyncPromo.ThrobberTime",
+                      base::TimeDelta::FromMilliseconds(time_double));
+}
+
+// TODO(dbeam): Replace with metricsHandler:recordHistogramCount when it exists.
+void SyncPromoHandler::HandleRecordSignInAttempts(const base::ListValue* args) {
+  double count_double;
+  CHECK(args->GetDouble(0, &count_double));
+  UMA_HISTOGRAM_COUNTS("SyncPromo.SignInAttempts", count_double);
+}
+
 void SyncPromoHandler::HandleUserFlowAction(const base::ListValue* args) {
   double action_double;
   CHECK(args->GetDouble(0, &action_double));
   int action = static_cast<int>(action_double);
-  if (action >= extension_misc::SYNC_PROMO_FIRST_VALID_JS_ACTION &&
-      action <= extension_misc::SYNC_PROMO_LAST_VALID_JS_ACTION) {
+
+  if (IsValidUserFlowAction(action))
     RecordUserFlowAction(action);
-  } else {
+  else
     NOTREACHED() << "Attempt to record invalid user flow action on sync promo.";
-  }
 
+  // TODO(dbeam): Should this be here or in a separate handler? This method was

[Evan Stade, 2011/11/15 17:45:19]

agree it should be separate

[Dan Beam, 2011/11/15 18:37:13]

Done.

+  // meant solely for UMA reporting.
   if (action == extension_misc::SYNC_PROMO_SKIP_CLICKED)
     SyncPromoUI::SetUserSkippedSyncPromo(Profile::FromWebUI(web_ui_));
 }
 
 int SyncPromoHandler::GetViewCount() const {
   // The locally persistent number of times the user has seen the sync promo.
   return prefs_->GetInteger(prefs::kSyncPromoViewCount);
 }
 
 int SyncPromoHandler::IncrementViewCountBy(unsigned int amount) {
   // Let the user increment by 0 if they really want.  It might be useful for a
   // weird way of sending preference change notifications...
   int adjusted = GetViewCount() + amount;
   prefs_->SetInteger(prefs::kSyncPromoViewCount, adjusted);
   return adjusted;
 }
 
 void SyncPromoHandler::RecordUserFlowAction(int action) {
   // Send an enumeration to our single user flow histogram.
   UMA_HISTOGRAM_ENUMERATION("SyncPromo.UserFlow", action,
                             extension_misc::SYNC_PROMO_BUCKET_BOUNDARY);
 }