Sync Promo: Add more UMA metrics.

chrome/browser/resources/sync_setup_overlay.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   const OptionsPage = options.OptionsPage;
 
   // Variable to track if a captcha challenge was issued. If this gets set to
   // true, it stays that way until we are told about successful login from
   // the browser.  This means subsequent errors (like invalid password) are
@@ skipping 520 matching lines @@
         this.showGaiaLogin_(args);
       else if (page == 'configure' || page == 'passphrase')
         this.showConfigure_(args);
 
       if (page == 'done')
         this.closeOverlay_();
       else
         this.showOverlay_();
     },
 
+    /**
+     * Changes the visibility of throbbers on this page.
+     * @param {boolean} visible Whether or not to set all throbber nodes
+     *     visible.
+     */
     setThrobbersVisible_: function(visible) {
       var throbbers = document.getElementsByClassName("throbber");
-        for (var i = 0; i < throbbers.length; i++)
-          throbbers[i].style.visibility = visible ? "visible" : "hidden";
+      var visibleOrHidden = visible ? "visible" : "hidden";

[Evan Stade, 2011/11/15 17:45:19]

revert the changes to this function

[Dan Beam, 2011/11/15 18:37:13]

OK, I can, but why?  I removed the loop invariant code motion, changed the
indentation to match our style guide (I thought), and added documentation so I
could @inheritDoc from the subclass...

[Evan Stade, 2011/11/15 22:46:41]

you can leave the docs and the indentation change. The rest of the changes are
performance related presumably but I think they are not worth the cost to
readability.

[Dan Beam, 2011/11/16 00:09:53]

Done.  Crankshaft should optimize the loop invariant code, i++ vs. i++, and
WebKit probably has a NodeList#length cache anyway, I'd guess...

+      for (var i = 0, l = throbbers.length; i < l; ++i)
+        throbbers[i].style.visibility = visibleOrHidden;
     },
 
     loginSetFocus_: function() {
       var email = $('gaia-email');
       var passwd = $('gaia-passwd');
       if (email && (email.value == null || email.value == "")) {
         email.focus();
       } else if (passwd) {
         passwd.focus();
       }
@@ skipping 182 matching lines @@
     sendCredentialsAndClose_: function() {
       if (!this.setErrorVisibility_()) {
         return false;
       }
 
       $('gaia-email').disabled = true;
       $('gaia-passwd').disabled = true;
       $('captcha-value').disabled = true;
       $('access-code').disabled = true;
 
-      $('logging-in-throbber').style.visibility = "visible";
+      this.setThrobbersVisible_(true);
 
       var f = $('gaia-login-form');
       var email = $('gaia-email');
       var passwd = $('gaia-passwd');
       var result = JSON.stringify({"user" : email.value,
                                    "pass" : passwd.value,
                                    "captcha" : f.captchaValue.value,
                                    "access_code" : f.accessCode.value});
       $('sign-in').disabled = true;
       chrome.send('SyncSetupSubmitAuth', [result]);
@@ skipping 76 matching lines @@
 
   SyncSetupOverlay.showStopSyncingUI = function() {
     SyncSetupOverlay.getInstance().showStopSyncingUI_();
   };
 
   // Export
   return {
     SyncSetupOverlay: SyncSetupOverlay
   };
 });