Sync Promo: Add more UMA metrics.

chrome/browser/resources/sync_promo.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(sail): Refactor options_page and remove this include.
 <include src="options/options_page.js"/>

[Evan Stade, 2011/11/15 17:45:19]

wtffff

[Dan Beam, 2011/11/15 18:37:13]

Wasn't me.  Want me to move?

[Evan Stade, 2011/11/15 22:46:41]

no

 <include src="sync_setup_overlay.js"/>
 
 cr.define('sync_promo', function() {
   /**
    * SyncPromo class
    * Subclass of options.SyncSetupOverlay that customizes the sync setup
    * overlay for use in the new tab page.
    * @class
    */
   function SyncPromo() {
@@ skipping 12 matching lines @@
       CREATE_ACCOUNT_CLICKED: i++,
       SKIP_CLICKED: i++,
       SIGN_IN_ATTEMPTED: i++,
       SIGNED_IN_SUCCESSFULLY: i++,
       ADVANCED_CLICKED: i++,
       ENCRYPTION_HELP_CLICKED: i++,
       CANCELLED_AFTER_SIGN_IN: i++,
       CONFIRMED_AFTER_SIGN_IN: i++,
       CLOSED_TAB: i++,
       CLOSED_WINDOW: i++,
+      LEFT_DURING_THROBBER: i++,
     };
   }());
 
   cr.addSingletonGetter(SyncPromo);
 
   SyncPromo.prototype = {
     __proto__: options.SyncSetupOverlay.prototype,
 
     showOverlay_: function() {
       $('sync-setup-overlay').hidden = false;
@@ skipping 53 matching lines @@
         if (!createAccountClickedAlready)
           chrome.send('SyncPromo:UserFlowAction',
                       [actions.CREATE_ACCOUNT_CLICKED]);
         createAccountClickedAlready = true;
       });
 
       // We listen to the <form>'s submit vs. the <input type="submit"> click so
       // we also track users that use the keyboard and press enter.
       var signInAttemptedAlready = false;
       $('gaia-login-form').addEventListener('submit', function() {
+        ++self.signInAttempts_;
         if (!signInAttemptedAlready)
           chrome.send('SyncPromo:UserFlowAction', [actions.SIGN_IN_ATTEMPTED]);
         signInAttemptedAlready = true;
       });
 
       var encryptionHelpClickedAlready = false;
       $('encryption-help-link').addEventListener('click', function() {
         if (!encryptionHelpClickedAlready )
           chrome.send('SyncPromo:UserFlowAction',
                       [actions.ENCRYPTION_HELP_CLICKED]);
@@ skipping 18 matching lines @@
       this.infographic_ = $('promo-infographic');
       this.learnMore_ = $('promo-information');
 
       this.infographic_.addEventListener('webkitTransitionEnd',
                                          this.toggleHidden_.bind(this));
       this.learnMore_.addEventListener('webkitTransitionEnd',
                                        this.toggleHidden_.bind(this));
     },
 
     /**
+     * Called when the page is unloading to record number of times a user tried
+     * to sign in and if they left while a throbber was running.
+     */
+    recordPageViewActions_: function() {
+      chrome.send('SyncPromo:RecordSignInAttempts', [this.signInAttempts_]);
+      if (typeof this.throbberStart_ == 'number' &&
+          window.isFinite(this.throbberStart_)) {
+        chrome.send('SyncPromo:UserFlowAction', [actions.LEFT_DURING_THROBBER]);
+      }
+    },
+
+    /**
      * Remove the [hidden] attribute from the node that was not previously
      * transitioning.
      * @param {Event} e A -webkit-transition end event.
      * @private
      */
     toggleHidden_: function(e) {
       // Only show the other element if the target of this event was hidden
       // (showing also triggers a transition end).
       if (e.target.hidden) {
         if (e.target === this.infographic_)
@@ skipping 26 matching lines @@
     },
 
     /**
      * Shows or hides the title of the promo page.
      * @param {Boolean} visible true if the title should be visible, false
      *     otherwise.
      * @private
      */
     setPromoTitleVisible_: function(visible) {
       $('promo-title').hidden = !visible;
-    }
+    },
+
+    /** @inheritDoc */
+    setThrobbersVisible_: function(visible) {
+      if (visible) {
+        this.throbberStart_ = Date.now();
+      } else {
+        if (typeof this.throbberStart_ == 'number' &&
+            window.isFinite(this.throbberStart_)) {
+          chrome.send('SyncPromo:RecordThrobberTime',
+                      [Date.now() - this.throbberStart_]);
+        }
+        this.throbberStart_ = null;
+      }
+      // Pass through to SyncSetupOverlay to handle display logic.
+      options.SyncSetupOverlay.prototype.setThrobbersVisible_.apply(
+          this, arguments);
+    },
+
+    /**
+     * Number of times a user attempted to sign in to GAIA during this page
+     * view.
+     * @private
+     */
+    signInAttempts_: 0,
+
+    /**
+     * The start time of a throbber on the page.
+     * @private
+     */
+    throbberStart_: null,

[Evan Stade, 2011/11/15 17:45:19]

why are you complicating this by setting it to null? use 0

[Dan Beam, 2011/11/15 18:37:13]

Done.

   };
 
   SyncPromo.showErrorUI = function() {
     SyncPromo.getInstance().showErrorUI_();
   };
 
   SyncPromo.showSetupUI = function() {
     SyncPromo.getInstance().showSetupUI_();
   };
 
@@ skipping 13 matching lines @@
   SyncPromo.showStopSyncingUI = function() {
     SyncPromo.getInstance().showStopSyncingUI_();
   };
 
   SyncPromo.initialize = function() {
     SyncPromo.getInstance().initializePage();
   };
 
   SyncPromo.setPromoTitleVisible = function(visible) {
     SyncPromo.getInstance().setPromoTitleVisible_(visible);
-  }
+  };
+
+  SyncPromo.recordPageViewActions = function() {
+    SyncPromo.getInstance().recordPageViewActions_();
+  };
 
   // Export
   return {
-    SyncPromo : SyncPromo
+    SyncPromo: SyncPromo
   };
 });
 
 var OptionsPage = options.OptionsPage;
 var SyncSetupOverlay = sync_promo.SyncPromo;
 window.addEventListener('DOMContentLoaded', sync_promo.SyncPromo.initialize);
+window.addEventListener('beforeunload',
+                        sync_promo.SyncPromo.recordPageViewActions);