Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8528053: Print Preview: Making margin selection sticky (part 2/2, again) (Closed)

Created:
9 years, 1 month ago by dpapad
Modified:
9 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, brettw-cc_chromium.org, arv (Not doing code reviews), darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Print Preview: Making margin selection sticky (part 2/2, again) This is a reland of http://codereview.chromium.org/8351048/ with minor changes to fix the compilation errors on the shared builders. BUG=102446 TEST=See bug description. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110055

Patch Set 1 #

Patch Set 2 : Fixing compilation error. #

Total comments: 1

Patch Set 3 : Fixing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+584 lines, -170 lines) Patch
M chrome/browser/printing/print_preview_message_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_message_handler.cc View 1 chunk +9 lines, -1 line 0 comments Download
M chrome/browser/printing/print_system_task_proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_system_task_proxy.cc View 2 chunks +9 lines, -12 lines 0 comments Download
M chrome/browser/resources/print_preview/margin_settings.js View 16 chunks +89 lines, -41 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 6 chunks +30 lines, -19 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.h View 5 chunks +25 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.cc View 1 9 chunks +84 lines, -54 lines 0 comments Download
A chrome/browser/ui/webui/print_preview_handler_unittest.cc View 1 chunk +261 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_ui.h View 3 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_ui.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/print_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/print_web_view_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/webui/print_preview.js View 2 chunks +2 lines, -2 lines 0 comments Download
M printing/page_size_margins.h View 1 2 2 chunks +9 lines, -1 line 0 comments Download
A printing/page_size_margins.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download
M printing/printing.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M printing/printing_context.cc View 1 2 chunks +8 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dpapad
Patch set 1 is a copy from http://codereview.chromium.org/8351048/. Patch set 2 addresses the shared builders ...
9 years, 1 month ago (2011-11-15 04:43:15 UTC) #1
Lei Zhang
http://codereview.chromium.org/8528053/diff/1020/printing/page_size_margins.h File printing/page_size_margins.h (right): http://codereview.chromium.org/8528053/diff/1020/printing/page_size_margins.h#newcode27 printing/page_size_margins.h:27: void GetCustomMarginsFromJobSettings(const base::DictionaryValue& settings, I think it's GetCustomMarginsFromJobSettings that ...
9 years, 1 month ago (2011-11-15 04:49:31 UTC) #2
Lei Zhang
LGTM with successful shared try bot compile steps.
9 years, 1 month ago (2011-11-15 05:30:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpapad@chromium.org/8528053/9022
9 years, 1 month ago (2011-11-15 06:18:28 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 07:56:19 UTC) #5 
Change committed as 110055

Powered by Google App Engine
This is Rietveld 408576698