Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3685)

Unified Diff: chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller_unittest.mm

Issue 8528052: Fix up fullscreen exit bubble messages to suggest Esc instead of F11 where appropriate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove irrelevant test Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller_unittest.mm
index 9070011c6607ed7e0b1e0a9ea6dc5b6e2051d6f9..054f0799b68b5a042b394eb611c2c67ac7522dfd 100644
--- a/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller_unittest.mm
@@ -109,16 +109,6 @@ TEST_F(FullscreenExitBubbleControllerTest, LabelWasReplaced) {
EXPECT_TRUE([controller_ exitLabel]);
}
-TEST_F(FullscreenExitBubbleControllerTest, LabelContainsShortcut) {
- NSString* shortcut = [FullscreenExitBubbleController keyCommandString];
- EXPECT_GT([shortcut length], 0U);
-
- NSString* message = [[[controller_ exitLabel] textStorage] string];
-
- NSRange range = [message rangeOfString:shortcut];
- EXPECT_NE(NSNotFound, range.location);
-}
-
TEST_F(FullscreenExitBubbleControllerTest, ShortcutText) {
ui::AcceleratorCocoa cmd_F(@"F", NSCommandKeyMask);
ui::AcceleratorCocoa cmd_shift_f(@"f", NSCommandKeyMask|NSShiftKeyMask);
« no previous file with comments | « chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm ('k') | chrome/browser/ui/fullscreen_exit_bubble.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698