Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 8528051: Revert 110021 - Broke CrOS compile (Closed)

Created:
9 years, 1 month ago by Ryan Sleevi
Modified:
9 years, 1 month ago
Reviewers:
Eric Dingle
CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 110021 - Broke CrOS compile Allow JSONWriter and JSONValueSerializer to ignore binary values when instructed to do so. Design discussion is available here: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/967eb64325c24f9c BUG=None TEST=base_unittests Review URL: http://codereview.chromium.org/8505033 TBR=ericdingle@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -128 lines) Patch
M base/json/json_value_serializer.h View 6 chunks +4 lines, -18 lines 0 comments Download
M base/json/json_value_serializer.cc View 2 chunks +2 lines, -27 lines 0 comments Download
M base/json/json_writer.h View 3 chunks +8 lines, -17 lines 0 comments Download
M base/json/json_writer.cc View 7 chunks +18 lines, -37 lines 0 comments Download
M base/json/json_writer_unittest.cc View 2 chunks +1 line, -27 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ryan Sleevi
9 years, 1 month ago (2011-11-15 03:23:58 UTC) #1
Ryan Sleevi
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS/builds/1561/steps/compile/logs/stdio#error1 chrome/browser/policy/configuration_policy_handler_chromeos.cc: In static member function 'static base::Value* policy::NetworkConfigurationPolicyHandler::SanitizeNetworkConfig(const base::Value*)': chrome/browser/policy/configuration_policy_handler_chromeos.cc:96:error: 'WriteWithOptionalEscape' is not a ...
9 years, 1 month ago (2011-11-15 03:25:02 UTC) #2
Eric Dingle
9 years, 1 month ago (2011-11-15 04:29:29 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698