Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 8528046: Change "Show All Downloads" link to "Show all files" (Closed)

Created:
9 years, 1 month ago by achuithb
Modified:
9 years, 1 month ago
Reviewers:
xiyuan
CC:
chromium-reviews, asanka, arv (Not doing code reviews), achuith+watch_chromium.org, Randy Smith (Not in Mondays)
Visibility:
Public.

Description

Change "Show All Downloads" link to "Show all files". Takes you to the file manager. BUG=chromium-os:22871 TEST=download a file on cros, link at the bottom of the downloads panel should say "Show all files". Clicking on it should open the filemanager at the downloads folder location. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110279

Patch Set 1 #

Patch Set 2 : rename to Show all files #

Patch Set 3 : rename to Show all files deux #

Patch Set 4 : missed one #

Patch Set 5 : replace again #

Patch Set 6 : minor #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -17 lines) Patch
M chrome/browser/resources/active_downloads.html View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/active_downloads.js View 1 2 3 4 5 6 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/active_downloads_ui.cc View 1 2 3 4 5 6 6 chunks +17 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
achuithb
Please review. Thanks!
9 years, 1 month ago (2011-11-15 23:12:06 UTC) #1
xiyuan
9 years, 1 month ago (2011-11-15 23:49:25 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698