Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: content/renderer/media/rtc_video_decoder.cc

Issue 8528045: corresponding change in CaptureVideoDecoder and RTCVideoDecoder due to pull model used in medi... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: code review Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/rtc_video_decoder.h ('k') | content/renderer/media/rtc_video_decoder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/rtc_video_decoder.cc
===================================================================
--- content/renderer/media/rtc_video_decoder.cc (revision 109978)
+++ content/renderer/media/rtc_video_decoder.cc (working copy)
@@ -4,8 +4,6 @@
#include "content/renderer/media/rtc_video_decoder.h"
-#include <deque>
-
#include "base/bind.h"
#include "base/callback.h"
#include "base/message_loop.h"
@@ -87,6 +85,34 @@
VideoDecoder::Pause(callback);
}
+void RTCVideoDecoder::Flush(const base::Closure& callback) {
+ if (MessageLoop::current() != message_loop_) {
+ message_loop_->PostTask(FROM_HERE,
+ base::Bind(&RTCVideoDecoder::Flush,
+ this, callback));
+ return;
+ }
+
+ DCHECK_EQ(MessageLoop::current(), message_loop_);
+
+ ReadCB read_cb;
+ {
+ base::AutoLock auto_lock(lock_);
+ if (!read_cb_.is_null()) {
+ std::swap(read_cb, read_cb_);
+ }
+ }
+
+ if (!read_cb.is_null()) {
+ scoped_refptr<media::VideoFrame> video_frame =
+ media::VideoFrame::CreateBlackFrame(visible_size_.width(),
+ visible_size_.height());
+ read_cb.Run(video_frame);
+ }
+
+ VideoDecoder::Flush(callback);
+}
+
void RTCVideoDecoder::Stop(const base::Closure& callback) {
if (MessageLoop::current() != message_loop_) {
message_loop_->PostTask(FROM_HERE,
@@ -141,6 +167,10 @@
return true;
}
+// TODO(wjia): this function can be split into two parts so that the |lock_|
+// can be removed.
+// First creates media::VideoFrame, then post a task onto |message_loop_|
+// to deliver that frame.
bool RTCVideoDecoder::RenderFrame(const cricket::VideoFrame* frame) {
// Called from libjingle thread.
DCHECK(frame);
« no previous file with comments | « content/renderer/media/rtc_video_decoder.h ('k') | content/renderer/media/rtc_video_decoder_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698