Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: chrome/browser/safe_browsing/signature_util_win_unittest.cc

Issue 8528043: Get all of the certificate data for downloads from the WinVerifyTrust result. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/signature_util_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/signature_util_win_unittest.cc
diff --git a/chrome/browser/safe_browsing/signature_util_win_unittest.cc b/chrome/browser/safe_browsing/signature_util_win_unittest.cc
index 86b78c66e10a58f83dd933ef029e9359c78f105a..501fefac6fcd98ec7a6fb25299fa1fdeaaf2f24d 100644
--- a/chrome/browser/safe_browsing/signature_util_win_unittest.cc
+++ b/chrome/browser/safe_browsing/signature_util_win_unittest.cc
@@ -59,6 +59,7 @@ TEST_F(SignatureUtilWinTest, UntrustedSignedBinary) {
EXPECT_EQ("Joe's-Software-Emporium", certs[0]->subject().common_name);
EXPECT_EQ("Root Agency", certs[1]->subject().common_name);
+ EXPECT_TRUE(signature_info.has_trusted());
EXPECT_FALSE(signature_info.trusted());
}
@@ -89,7 +90,7 @@ TEST_F(SignatureUtilWinTest, UnsignedBinary) {
signature_util->CheckSignature(testdata_path_.Append(L"unsigned.exe"),
&signature_info);
EXPECT_EQ(0, signature_info.certificate_chain_size());
- EXPECT_FALSE(signature_info.trusted());
+ EXPECT_FALSE(signature_info.has_trusted());
}
TEST_F(SignatureUtilWinTest, NonExistentBinary) {
@@ -99,7 +100,7 @@ TEST_F(SignatureUtilWinTest, NonExistentBinary) {
signature_util->CheckSignature(testdata_path_.Append(L"doesnotexist.exe"),
&signature_info);
EXPECT_EQ(0, signature_info.certificate_chain_size());
- EXPECT_FALSE(signature_info.trusted());
+ EXPECT_FALSE(signature_info.has_trusted());
}
} // namespace safe_browsing
« no previous file with comments | « chrome/browser/safe_browsing/signature_util_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698