gtk/bookmarks: Cache BookmarkModel in BookmarkBubbleGtk.

chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.h"
 
 #include <gtk/gtk.h>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 71 matching lines @@
     }
   }
 }
 
 BookmarkBubbleGtk::BookmarkBubbleGtk(GtkWidget* anchor,
                                      Profile* profile,
                                      const GURL& url,
                                      bool newly_bookmarked)
     : url_(url),
       profile_(profile),
+      model_(profile->GetBookmarkModel()),
       theme_service_(GtkThemeService::GetFrom(profile_)),
       anchor_(anchor),
       content_(NULL),
       name_entry_(NULL),
       folder_combo_(NULL),
       bubble_(NULL),
       factory_(this),
       newly_bookmarked_(newly_bookmarked),
       apply_edits_(true),
       remove_bookmark_(false) {
@@ skipping 94 matching lines @@
 
 BookmarkBubbleGtk::~BookmarkBubbleGtk() {
   DCHECK(!content_);  // |content_| should have already been destroyed.
 
   DCHECK(g_bubble);
   g_bubble = NULL;
 
   if (apply_edits_) {
     ApplyEdits();
   } else if (remove_bookmark_) {
-    BookmarkModel* model = profile_->GetBookmarkModel();
-    const BookmarkNode* node = model->GetMostRecentlyAddedNodeForURL(url_);
+    const BookmarkNode* node = model_->GetMostRecentlyAddedNodeForURL(url_);
     if (node)
-      model->Remove(node->parent(), node->parent()->GetIndexOf(node));
+      model_->Remove(node->parent(), node->parent()->GetIndexOf(node));
   }
 }
 
 void BookmarkBubbleGtk::OnDestroy(GtkWidget* widget) {
   // We are self deleting, we have a destroy signal setup to catch when we
   // destroyed (via the BubbleGtk being destroyed), and delete ourself.
   content_ = NULL;  // We are being destroyed.
   delete this;
 }
 
@@ skipping 42 matching lines @@
 
   apply_edits_ = false;
   remove_bookmark_ = true;
   bubble_->Close();
 }
 
 void BookmarkBubbleGtk::ApplyEdits() {
   // Set this to make sure we don't attempt to apply edits again.
   apply_edits_ = false;
 
-  BookmarkModel* model = profile_->GetBookmarkModel();
-  const BookmarkNode* node = model->GetMostRecentlyAddedNodeForURL(url_);
+  const BookmarkNode* node = model_->GetMostRecentlyAddedNodeForURL(url_);
   if (node) {
     const string16 new_title(
         UTF8ToUTF16(gtk_entry_get_text(GTK_ENTRY(name_entry_))));
 
     if (new_title != node->GetTitle()) {
-      model->SetTitle(node, new_title);
+      model_->SetTitle(node, new_title);
       UserMetrics::RecordAction(
           UserMetricsAction("BookmarkBubble_ChangeTitleInBubble"));
     }
 
     int index = gtk_combo_box_get_active(GTK_COMBO_BOX(folder_combo_));
 
     // Last index means 'Choose another folder...'
     if (index < folder_combo_model_->GetItemCount() - 1) {
       const BookmarkNode* new_parent = folder_combo_model_->GetNodeAt(index);
       if (new_parent != node->parent()) {
         UserMetrics::RecordAction(
             UserMetricsAction("BookmarkBubble_ChangeParent"));
-        model->Move(node, new_parent, new_parent->child_count());
+        model_->Move(node, new_parent, new_parent->child_count());
       }
     }
   }
 }
 
 std::string BookmarkBubbleGtk::GetTitle() {
-  BookmarkModel* bookmark_model= profile_->GetBookmarkModel();
-  const BookmarkNode* node =
-      bookmark_model->GetMostRecentlyAddedNodeForURL(url_);
+  const BookmarkNode* node = model_->GetMostRecentlyAddedNodeForURL(url_);
   if (!node) {
     NOTREACHED();
     return std::string();
   }
 
   return UTF16ToUTF8(node->GetTitle());
 }
 
 void BookmarkBubbleGtk::ShowEditor() {
-  const BookmarkNode* node =
-      profile_->GetBookmarkModel()->GetMostRecentlyAddedNodeForURL(url_);
+  const BookmarkNode* node = model_->GetMostRecentlyAddedNodeForURL(url_);
 
   // Commit any edits now.
   ApplyEdits();
 
   // Closing might delete us, so we'll cache what we need on the stack.
   Profile* profile = profile_;
   GtkWindow* toplevel = GTK_WINDOW(gtk_widget_get_toplevel(anchor_));
 
   // Close the bubble, deleting the C++ objects, etc.
   bubble_->Close();
 
   if (node) {
     BookmarkEditor::Show(toplevel, profile,
                          BookmarkEditor::EditDetails::EditNode(node),
                          BookmarkEditor::SHOW_TREE);
   }
 }
 
 void BookmarkBubbleGtk::InitFolderComboModel() {
-  const BookmarkNode* node =
-      profile_->GetBookmarkModel()->GetMostRecentlyAddedNodeForURL(url_);
+  const BookmarkNode* node = model_->GetMostRecentlyAddedNodeForURL(url_);
   DCHECK(node);
 
-  folder_combo_model_.reset(new RecentlyUsedFoldersComboModel(
-      profile_->GetBookmarkModel(), node));
+  folder_combo_model_.reset(new RecentlyUsedFoldersComboModel(model_, node));
 
   // We always have nodes + 1 entries in the combo.  The last entry will be
   // the 'Select another folder...' entry that opens the bookmark editor.
   for (int i = 0; i < folder_combo_model_->GetItemCount(); ++i) {
     gtk_combo_box_append_text(GTK_COMBO_BOX(folder_combo_),
         UTF16ToUTF8(folder_combo_model_->GetItemAt(i)).c_str());
   }
 
   gtk_combo_box_set_active(GTK_COMBO_BOX(folder_combo_),
                            folder_combo_model_->node_parent_index());
 }