change presubmit to run co19 tests

frog/presubmit.py

Index: frog/presubmit.py
diff --git a/frog/presubmit.py b/frog/presubmit.py
index 375e2591e84ba5dcd2704b4af2feceef372e7ad7..4c05438dd611a71bfe086c70df9ae7248d91a35f 100755
--- a/frog/presubmit.py
+++ b/frog/presubmit.py
@@ -55,27 +55,13 @@ def main(args):
   print 'Started'
   start = time.time()
   RunCommand('./frog.py',
-             '--vm_flags=--compile_all --enable_type_checks --enable_asserts',
-             '--', '--enable_type_checks', '--out=frogsh', 'frog.dart')
+             '--vm_flags=--enable_type_checks --enable_asserts', '--',

[ahe, 2011/11/11 12:46:11]

Could we keep --compile_all for dart_bin?

[jimhug, 2011/11/11 14:45:39]

I agree that we should keep this to maximize coverage in the VM.  It's weird to
realize that Peter added this flag only two weeks ago and at the time we had no
idea how long it would be until this would also work for frog itself...

[Jennifer Messerly, 2011/11/11 18:10:02]

Haha, yeah, I didn't know this was meant to test the VM! I'll fix.

+             '--compile_all', '--enable_type_checks', '--out=frogsh',
+             'frog.dart')
   elapsed = time.time() - start
   mode = 'in checked mode + compile all'
   print 'Compiling on Dart VM took %s seconds %s' % (b(elapsed), b(mode))
 
-  # VM Checked, produces checked
-  start = time.time()
-  RunCommand('./frog.py',
-             '--vm_flags=--enable_type_checks --enable_asserts',
-             '--', '--enable_type_checks', '--out=frogsh', 'frog.dart')
-  elapsed = time.time() - start
-  mode = 'in checked mode'
-  print 'Compiling on Dart VM took %s seconds %s' % (b(elapsed), b(mode))
-
-  # VM Normal, produces checked
-  start = time.time()
-  RunCommand('./frog.py', '--out=frogsh', '--enable_type_checks', 'frog.dart')
-  elapsed = time.time() - start
-  print 'Compiling on Dart VM took %s seconds' % b(elapsed)
-
   # Selfhost Checked
   start = time.time()
   RunCommand('./frogsh', '--out=frogsh', '--enable_type_checks', 'frog.dart',
@@ -86,15 +72,23 @@ def main(args):
   print 'Generated %s frogsh is %s kB' % (b('checked'), b(size))
 
   RunCommand('../tools/build.py', '--mode=release')
-  test_cmd = ['../tools/test.py', '--component=frog,frogsh,leg',
-              '--report', '--timeout=5', '--progress=color',
-              '--mode=release', '--checked']
+  test_cmd = ['../tools/test.py', '--report', '--timeout=10',

[Siggi Cherem (dart-lang), 2011/11/11 00:10:53]

why the increase to 10? 

[Jennifer Messerly, 2011/11/11 00:21:14]

Oops, I think my comment got lost when I uploaded a new version. See here:
http://codereview.chromium.org/8528015/diff/1/frog/presubmit.py#newcode75

+              '--progress=color', '--mode=release', '--checked']
   if args[1:]:
+    test_cmd.append('--component=frogsh,leg')
     test_cmd.extend(args[1:])
+    RunCommand(*test_cmd, verbose=True)
   else:
-    test_cmd.extend(['language', 'corelib', 'leg', 'isolate',
-                     'peg', 'leg_only', 'frog'])
-  RunCommand(*test_cmd, verbose=True)
+    # Run frog.py on the corelib tests, so we get some frog.py coverage.
+    cmd = test_cmd + ['--component=frog', 'corelib']
+    RunCommand(*cmd, verbose=True)
+    # Run leg and frogsh on most of the tests. TODO: add co19 here
+    cmd = test_cmd + ['--component=frogsh,leg', 'language', 'corelib', 'leg',
+                      'isolate', 'peg', 'leg_only', 'frog']
+    RunCommand(*cmd, verbose=True)
+    # TODO: leg doesn't work with co19 yet, so run it separately
+    cmd = test_cmd + ['--component=frogsh', 'co19']
+    RunCommand(*cmd, verbose=True)
 
 if __name__ == '__main__':
   try: