Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: frog/presubmit.py

Issue 8528015: change presubmit to run co19 tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: update co19-frog.status Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/co19/co19-frog.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/presubmit.py
diff --git a/frog/presubmit.py b/frog/presubmit.py
index 375e2591e84ba5dcd2704b4af2feceef372e7ad7..36845293db33f7712ed5617a79bc4e36c53d55d7 100755
--- a/frog/presubmit.py
+++ b/frog/presubmit.py
@@ -56,26 +56,12 @@ def main(args):
start = time.time()
RunCommand('./frog.py',
'--vm_flags=--compile_all --enable_type_checks --enable_asserts',
- '--', '--enable_type_checks', '--out=frogsh', 'frog.dart')
+ '--', '--compile_all', '--enable_type_checks', '--out=frogsh',
+ 'frog.dart')
elapsed = time.time() - start
mode = 'in checked mode + compile all'
print 'Compiling on Dart VM took %s seconds %s' % (b(elapsed), b(mode))
- # VM Checked, produces checked
- start = time.time()
- RunCommand('./frog.py',
- '--vm_flags=--enable_type_checks --enable_asserts',
- '--', '--enable_type_checks', '--out=frogsh', 'frog.dart')
- elapsed = time.time() - start
- mode = 'in checked mode'
- print 'Compiling on Dart VM took %s seconds %s' % (b(elapsed), b(mode))
-
- # VM Normal, produces checked
- start = time.time()
- RunCommand('./frog.py', '--out=frogsh', '--enable_type_checks', 'frog.dart')
- elapsed = time.time() - start
- print 'Compiling on Dart VM took %s seconds' % b(elapsed)
-
# Selfhost Checked
start = time.time()
RunCommand('./frogsh', '--out=frogsh', '--enable_type_checks', 'frog.dart',
@@ -86,15 +72,23 @@ def main(args):
print 'Generated %s frogsh is %s kB' % (b('checked'), b(size))
RunCommand('../tools/build.py', '--mode=release')
- test_cmd = ['../tools/test.py', '--component=frog,frogsh,leg',
- '--report', '--timeout=5', '--progress=color',
- '--mode=release', '--checked']
+ test_cmd = ['../tools/test.py', '--report', '--timeout=10',
+ '--progress=color', '--mode=release', '--checked']
if args[1:]:
+ test_cmd.append('--component=frogsh,leg')
test_cmd.extend(args[1:])
+ RunCommand(*test_cmd, verbose=True)
else:
- test_cmd.extend(['language', 'corelib', 'leg', 'isolate',
- 'peg', 'leg_only', 'frog'])
- RunCommand(*test_cmd, verbose=True)
+ # Run frog.py on the corelib tests, so we get some frog.py coverage.
+ cmd = test_cmd + ['--component=frog', 'corelib']
+ RunCommand(*cmd, verbose=True)
+ # Run leg and frogsh on most of the tests. TODO: add co19 here
+ cmd = test_cmd + ['--component=frogsh,leg', 'language', 'corelib', 'leg',
+ 'isolate', 'peg', 'leg_only', 'frog']
+ RunCommand(*cmd, verbose=True)
+ # TODO: leg doesn't work with co19 yet, so run it separately
+ cmd = test_cmd + ['--component=frogsh', 'co19']
+ RunCommand(*cmd, verbose=True)
if __name__ == '__main__':
try:
« no previous file with comments | « no previous file | tests/co19/co19-frog.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698