Issue 8528014: Remove use_only_pure_views flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8528014: Remove use_only_pure_views flag (Closed)

Created:
9 years, 1 month ago by Emmanuel Saint-loubert-Bié

Modified:
9 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, dhollowa

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

IsPureViews() is always true under USE_AURA and TOUCH_UI at compile time (as before). For other configurations it can also be set by a command line option at run-time (also as before). What changes is that we are removing use_only_pure_views as a separate GYP flag which we no longer really need. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109571

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -28 lines)			Patch
M	build/common.gypi	View	9 chunks	+3 lines, -26 lines	0 comments	Download
M	chrome/browser/chromeos/notifications/notification_panel.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/widget/widget.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/8528014/1

9 years, 1 month ago (2011-11-11 01:53:45 UTC) #3

Change committed as 109571

Expand Messages | Collapse Messages