Page zoom improvements

chrome/browser/resources/options/advanced_options.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
 var OptionsPage = options.OptionsPage;
 
   //
   // AdvancedOptions class
@@ skipping 45 matching lines @@
       }
 
       $('fontSettingsCustomizeFontsButton').onclick = function(event) {
         OptionsPage.navigateToPage('fonts');
         chrome.send('coreOptionsUserMetricsAction', ['Options_FontSettings']);
       };
       $('defaultFontSize').onchange = function(event) {
         chrome.send('defaultFontSizeAction',
             [String(event.target.options[event.target.selectedIndex].value)]);
       };
+      $('defaultZoomFactor').onchange = function(event) {
+        chrome.send('defaultZoomFactorAction',
+            [String(event.target.options[event.target.selectedIndex].value)]);
+      };
+
       $('language-button').onclick = function(event) {
         OptionsPage.navigateToPage('languages');
         chrome.send('coreOptionsUserMetricsAction',
             ['Options_LanuageAndSpellCheckSettings']);
       };
 
       if (cr.isWindows || cr.isMac) {
         $('certificatesManageButton').onclick = function(event) {
           chrome.send('showManageSSLCertificates');
         };
@@ skipping 88 matching lines @@
     // Add/Select Custom Option in the font size label list.
     if (!$('Custom')) {
       var option = new Option(localStrings.getString('fontSizeLabelCustom'),
                               -1, false, true);
       option.setAttribute("id", "Custom");
       selectCtl.add(option);
     }
     $('Custom').selected = true;
   };
 
+  AdvancedOptions.SetupPageZoomSelector = function(items) {

[James Hawkins, 2011/11/15 18:35:51]

Document the method and |items|.

[csilv, 2011/11/19 00:17:45]

Done.

+    var element = $('defaultZoomFactor');
+
+    // Remove any existing content.
+    element.textContent = '';
+
+    // Insert new child nodes into select element.
+    var value, title, selected;
+    for (var i = 0; i < items.length; i++) {
+      title = items[i][0];
+      value = items[i][1];
+      selected = items[i][2];
+      element.appendChild(new Option(title, value, false, selected));
+    }
+  };
+
   // Set the enabled state for the autoOpenFileTypesResetToDefault button.
   AdvancedOptions.SetAutoOpenFileTypesDisabledAttribute = function(disabled) {
     if (!cr.isChromeOS) {
       $('autoOpenFileTypesResetToDefault').disabled = disabled;
 
       if (disabled)
         $('auto-open-file-types-label').classList.add('disabled');
       else
         $('auto-open-file-types-label').classList.remove('disabled');
     }
@@ skipping 44 matching lines @@
         proxySectionElm.parentNode.removeChild(proxySectionElm);
     }
   };
 
   // Export
   return {
     AdvancedOptions: AdvancedOptions
   };
 
 });