Page zoom improvements

content/public/common/page_zoom.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/public/common/page_zoom.h"
+
+namespace content {
+
+const double kMinimumZoomFactor = 0.25;
+const double kMaximumZoomFactor = 5.0;
+
+// Note: If you change the contents of kPresetZoomFactors, be sure to update
+// kPresetZoomFactorsCount also.
+const double kPresetZoomFactors[] = { 0.25, 0.333, 0.5, 0.666, 0.75, 0.9, 1.0,
+                                      1.1, 1.25, 1.5, 1.75, 2.0, 2.5, 3.0, 4.0,
+                                      5.0 };
+const int kPresetZoomFactorsCount = 16;

[James Hawkins, 2011/11/14 18:09:05]

Isn't there a macro that does this for you?  Like arraysize() or something. Then
you can remove the comment above.

[csilv, 2011/11/14 23:10:29]

I wish this were the case.  Yes, there is an arraysize macro, but it doesn't
work for cases like this.  arraysize only works when you define the array in the
same implementation.  When the array is an extern, the size is unknown so
attempting to use arraysize just leads to a compiler error.

I could put the size in the header, but that seems riskier than having it
defined here.

This might all be a moot point.  You asked me to see if I can refactor the two
places this array is used... so if I succeed in doing that, this array can be
moved to the implementation and then I will be able to use arraysize().  Let me
proceed in that direction.

[csilv, 2011/11/15 02:26:49]

Done.

+
+const double kPageZoomEpsilon = 0.005;

[James Hawkins, 2011/11/14 18:09:05]

Document var.

[csilv, 2011/11/14 23:10:29]

It's documented in the header already.  The style guidelines say that we
shouldn't duplicate comments in both the header and implementation.  Are you
asking for redundant documentation, or more detailed documentation?

[csilv, 2011/11/15 02:26:49]

Improved documentation.  This is an internal value now.

On 2011/11/14 23:10:29, csilv wrote:

+
+}  // namespace content
+