Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 8527025: Remove TOUCH_UI definition and make use_virtual_keyboard an independant var. (Closed)

Created:
9 years, 1 month ago by Emmanuel Saint-loubert-Bié
Modified:
9 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, tfarina, dhollowa, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove TOUCH_UI definition and make use_virtual_keyboard an independant variable. BUG=105046 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111069

Patch Set 1 #

Patch Set 2 : Fix for iBus. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -33 lines) Patch
M base/base.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 10 chunks +18 lines, -31 lines 1 comment Download
M views/views.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Emmanuel Saint-loubert-Bié
Some touch cleanup.
9 years, 1 month ago (2011-11-21 19:01:03 UTC) #1
sky
LGTM
9 years, 1 month ago (2011-11-21 21:30:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/8527025/3001
9 years, 1 month ago (2011-11-21 22:15:49 UTC) #3
commit-bot: I haz the power
Presubmit check for 8527025-3001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 1 month ago (2011-11-21 22:16:27 UTC) #4
Emmanuel Saint-loubert-Bié
Nico, Please review base/base.gypi as OWNERs. Thanks -- Emmanuel
9 years, 1 month ago (2011-11-21 22:21:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/8527025/3001
9 years, 1 month ago (2011-11-21 22:31:15 UTC) #6
Nico
It sounds like there will be more CLs for this, so please file a tracking ...
9 years, 1 month ago (2011-11-21 22:45:02 UTC) #7
Emmanuel Saint-loubert-Bié
I should have though if that. Thanks Nico. -- Emmanuel
9 years, 1 month ago (2011-11-21 22:50:00 UTC) #8
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
9 years, 1 month ago (2011-11-22 00:08:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/8527025/3001
9 years, 1 month ago (2011-11-22 00:11:27 UTC) #10
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 01:25:28 UTC) #11
Change committed as 111069

Powered by Google App Engine
This is Rietveld 408576698