Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8527020: Cleanup: Remove unneeded forward declarations in ppapi. (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Cleanup: Remove unneeded forward declarations in ppapi. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109595

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -185 lines) Patch
M ppapi/c/private/ppb_flash_file.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/cpp/dev/font_dev.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/cpp/dev/url_util_dev.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/cpp/dev/widget_dev.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/cpp/file_system.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ppapi/cpp/graphics_3d.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/cpp/graphics_3d_client.h View 1 3 chunks +2 lines, -5 lines 0 comments Download
M ppapi/cpp/image_data.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/cpp/instance.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/cpp/var.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_resource_tracker.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/desc_based_handle.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/method_map.h View 1 2 chunks +3 lines, -7 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/scriptable_handle.h View 1 2 chunks +3 lines, -8 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/service_runtime.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/proxy/dispatcher.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/proxy/enter_proxy.h View 1 3 chunks +2 lines, -6 lines 0 comments Download
M ppapi/proxy/host_dispatcher.h View 1 2 chunks +1 line, -12 lines 0 comments Download
M ppapi/proxy/host_var_serialization_rules.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
ppapi/proxy/plugin_dispatcher.h View 1 2 chunks +2 lines, -6 lines 0 comments Download
M ppapi/proxy/plugin_resource_tracker.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/proxy/plugin_var_tracker.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/ppb_broker_proxy.h View 1 4 chunks +4 lines, -6 lines 0 comments Download
M ppapi/proxy/ppb_buffer_proxy.h View 1 4 chunks +4 lines, -6 lines 0 comments Download
M ppapi/proxy/ppb_context_3d_proxy.h View 1 2 chunks +1 line, -4 lines 0 comments Download
M ppapi/proxy/ppb_cursor_control_proxy.h View 1 4 chunks +4 lines, -6 lines 0 comments Download
M ppapi/proxy/ppb_file_chooser_proxy.h View 1 2 chunks +1 line, -6 lines 0 comments Download
M ppapi/proxy/ppb_file_ref_proxy.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M ppapi/proxy/ppb_file_system_proxy.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M ppapi/proxy/ppb_flash_proxy.h View 1 4 chunks +4 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_font_proxy.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M ppapi/proxy/ppb_surface_3d_proxy.h View 1 4 chunks +4 lines, -6 lines 0 comments Download
M ppapi/proxy/ppb_text_input_proxy.h View 1 3 chunks +4 lines, -6 lines 0 comments Download
ppapi/proxy/ppb_var_deprecated_proxy.h View 1 4 chunks +4 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_video_capture_proxy.h View 1 4 chunks +7 lines, -6 lines 0 comments Download
M ppapi/proxy/ppp_class_proxy.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/proxy/ppp_instance_proxy.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M ppapi/proxy/proxy_channel.h View 1 2 chunks +1 line, -3 lines 0 comments Download
ppapi/proxy/proxy_module.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/shared_impl/url_request_info_impl.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/shared_impl/video_decoder_impl.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M ppapi/tests/test_core.h View 1 2 chunks +3 lines, -7 lines 0 comments Download
M ppapi/tests/test_graphics_2d.h View 1 3 chunks +6 lines, -5 lines 0 comments Download
M ppapi/tests/test_video_decoder.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
9 years, 1 month ago (2011-11-11 02:36:12 UTC) #1
piman
LGTM http://codereview.chromium.org/8527020/diff/1/ppapi/cpp/graphics_3d_client.h File ppapi/cpp/graphics_3d_client.h (right): http://codereview.chromium.org/8527020/diff/1/ppapi/cpp/graphics_3d_client.h#newcode17 ppapi/cpp/graphics_3d_client.h:17: class Widget_Dev; While you're here, those two should ...
9 years, 1 month ago (2011-11-11 03:42:50 UTC) #2
Lei Zhang
On 2011/11/11 03:42:50, piman wrote: > LGTM > > http://codereview.chromium.org/8527020/diff/1/ppapi/cpp/graphics_3d_client.h > File ppapi/cpp/graphics_3d_client.h (right): > ...
9 years, 1 month ago (2011-11-11 04:31:50 UTC) #3
piman
LGTM. nice!
9 years, 1 month ago (2011-11-11 06:36:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8527020/3002
9 years, 1 month ago (2011-11-11 07:54:39 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-11 07:54:43 UTC) #6 
Can't process patch for file ppapi/proxy/proxy_module.h.
File's status is None, patchset upload is incomplete.

Powered by Google App Engine
This is Rietveld 408576698