Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 8527018: Refactor ChannelAuthenticator so that it can be used with Authenticator. (Closed)

Created:
9 years, 1 month ago by Sergey Ulanov
Modified:
9 years, 1 month ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, Paweł Hajdan Jr., dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Refactor ChannelAuthenticator so that it can be used with Authenticator. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110051

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -53 lines) Patch
M remoting/protocol/channel_authenticator.h View 6 chunks +12 lines, -10 lines 0 comments Download
M remoting/protocol/channel_authenticator.cc View 7 chunks +14 lines, -10 lines 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/jingle_stream_connector.h View 2 chunks +3 lines, -7 lines 0 comments Download
M remoting/protocol/jingle_stream_connector.cc View 5 chunks +17 lines, -20 lines 0 comments Download
M remoting/protocol/pepper_stream_channel.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sergey Ulanov
9 years, 1 month ago (2011-11-11 01:31:24 UTC) #1
Wez
LGTM Given that our existing channel authentication is asymmetric, would it make sense to have ...
9 years, 1 month ago (2011-11-11 02:01:10 UTC) #2
Sergey Ulanov
On 2011/11/11 02:01:10, Wez wrote: > LGTM > > Given that our existing channel authentication ...
9 years, 1 month ago (2011-11-11 02:07:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/8527018/1
9 years, 1 month ago (2011-11-15 04:38:49 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 05:38:58 UTC) #5
Change committed as 110051

Powered by Google App Engine
This is Rietveld 408576698