Makes NativeWidgetGtk create TYPE_CONTROL widgets initially

Makes NativeWidgetGtk create TYPE_CONTROL widgets initially
visible. This matches windows and aura.

Also fixes bug where we were setting incorrect name on widget.

BUG=chromium-os:22592
TEST=see bug
R=ben@chromium.org,oshima@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109682

[Ben Goodger (Google), 2011-11-10 21:44:56]

LGTM

On Thu, Nov 10, 2011 at 1:27 PM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google), oshima,
>
> Description:
> Makes NativeWidgetGtk create TYPE_CONTROL widgets initially
> visible. This matches windows and aura.
>
> Also fixes bug where we were setting incorrect name on widget.
>
> BUG=chromium-os:22592
> TEST=see bug
> R=ben@chromium.org,oshima@**chromium.org <oshima@chromium.org>
>
>
> Please review this at
http://codereview.chromium.**org/8527008/<http://codereview.chromium.org/8527...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M views/widget/native_widget_**gtk.cc
>
>
> Index: views/widget/native_widget_**gtk.cc
> diff --git a/views/widget/native_widget_**gtk.cc
> b/views/widget/native_widget_**gtk.cc
> index face60c6710dad0a4b85e10a14af07**c60c588313..**
> 88a2f6e83d136beb781dffeab8d1be**18e9cc1c1b 100644
> --- a/views/widget/native_widget_**gtk.cc
> +++ b/views/widget/native_widget_**gtk.cc
> @@ -1972,7 +1972,7 @@ void NativeWidgetGtk::**CreateGtkWidget(const
> Widget::InitParams& params) {
>     if (!params.parent && !null_parent_) {
>       GtkWidget* popup = gtk_window_new(GTK_WINDOW_**POPUP);
>       null_parent_ = gtk_fixed_new();
> -      gtk_widget_set_name(widget_, "views-gtkwidget-null-parent")**;
> +      gtk_widget_set_name(null_**parent_, "views-gtkwidget-null-parent")*
> *;
>       gtk_container_add(GTK_**CONTAINER(popup), null_parent_);
>       gtk_widget_realize(null_**parent_);
>     }
> @@ -2006,6 +2006,10 @@ void NativeWidgetGtk::**CreateGtkWidget(const
> Widget::InitParams& params) {
>           { 0, 0, params.bounds.width(), params.bounds.height() };
>       gtk_widget_size_allocate(**widget_, &alloc);
>     }
> +    if (params.type == Widget::InitParams::TYPE_**CONTROL) {
> +      // Controls are initially visible.
> +      gtk_widget_show(widget_);
> +    }
>   } else {
>     Widget::InitParams::Type type = params.type;
>     if (type == Widget::InitParams::TYPE_**BUBBLE &&
>
>
>

[oshima, 2011-11-10 21:56:35]

LGTM

[commit-bot: I haz the power, 2011-11-10 22:01:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/8527008/1

[commit-bot: I haz the power, 2011-11-11 01:10:18]

Try job failure for 8527008-1 (retry) (retry) on win_rel for step "ui_tests"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2011-11-11 18:20:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/8527008/1

[commit-bot: I haz the power, 2011-11-11 20:38:48]

Change committed as 109682