Change the Chrome OS PKCS #11 module from libopencryptoki.so to libchaps.so.

Change the Chrome OS PKCS #11 module from libopencryptoki.so to libchaps.so.

This CL is part of a larger effort to replace opencryptoki as the PKCS #11 layer in Chrome OS.  In this first phase, libchaps.so forwards requests to a daemon (chapsd) which loads opencryptoki to service the requests.  You can find the Chaps design doc here: https://docs.google.com/a/google.com/document/d/1TQFc6GABKa1JgwUx2hIcxAHQ329fkd03yYlGxhfHQlQ/edit

Change-Id: I42962c4703413039641b6ede40caaf0c97ab900e

BUG=chromium-os:21005
TEST=* Ensure previously existing certs still exist.
     * Import new cert and private key from PKCS12 file.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110435

[Darren Krahn, 2011-11-14 17:41:53]

This CL is part of a larger effort to replace opencryptoki as the PKCS #11 layer
in Chrome OS.  In this first phase, libchaps.so forwards requests to a daemon
(chapsd) which loads opencryptoki to service the requests.  You can find the
chaps design doc here:
https://docs.google.com/a/google.com/document/d/1TQFc6GABKa1JgwUx2hIcxAHQ329f...

[gauravsh, 2011-11-14 17:49:24]

Please include the short rationale for the change in the commit description too
(you can do this by directly "Edit Issue" on the CL). 

Also, "Change the Chrome OS..." (note the tense).

http://codereview.chromium.org/8527006/diff/1/crypto/nss_util.cc
File crypto/nss_util.cc (right):

http://codereview.chromium.org/8527006/diff/1/crypto/nss_util.cc#newcode60
crypto/nss_util.cc:60: const char kOpencryptokiPath[] = "libchaps.so";
Doesn't this need to be the complete absolute path?

[Darren Krahn, 2011-11-14 23:32:26]

http://codereview.chromium.org/8527006/diff/1/crypto/nss_util.cc
File crypto/nss_util.cc (right):

http://codereview.chromium.org/8527006/diff/1/crypto/nss_util.cc#newcode60
crypto/nss_util.cc:60: const char kOpencryptokiPath[] = "libchaps.so";
No... because libchaps.so is in /usr/lib

On 2011/11/14 17:49:24, gauravsh wrote:
> Doesn't this need to be the complete absolute path?

[gauravsh, 2011-11-14 23:43:34]

lgtm

[wtc, 2011-11-15 03:13:58]

LGTM.

http://codereview.chromium.org/8527006/diff/1/crypto/nss_util.cc
File crypto/nss_util.cc (right):

http://codereview.chromium.org/8527006/diff/1/crypto/nss_util.cc#newcode60
crypto/nss_util.cc:60: const char kOpencryptokiPath[] = "libchaps.so";

The comment on line 58 and the constant names on lines 59-60
should be updated to mention chaps instead of opencryptoki,
or use something more generic such as "Chrome OS PKCS #11
library".

[Darren Krahn, 2011-11-16 17:41:16]

http://codereview.chromium.org/8527006/diff/1/crypto/nss_util.cc
File crypto/nss_util.cc (right):

http://codereview.chromium.org/8527006/diff/1/crypto/nss_util.cc#newcode60
crypto/nss_util.cc:60: const char kOpencryptokiPath[] = "libchaps.so";
On 2011/11/15 03:13:58, wtc wrote:
> 
> The comment on line 58 and the constant names on lines 59-60
> should be updated to mention chaps instead of opencryptoki,
> or use something more generic such as "Chrome OS PKCS #11
> library".

Done.

[commit-bot: I haz the power, 2011-11-17 00:05:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dkrahn@chromium.org/8527006/4001

[commit-bot: I haz the power, 2011-11-17 05:12:04]

Change committed as 110435