Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 8526019: Removing select_file_dialog.cc which is dead code. (Closed)

Created:
9 years, 1 month ago by Emmanuel Saint-loubert-Bié
Modified:
9 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Removing dead code. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109581

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -493 lines) Patch
D chrome/browser/ui/views/select_file_dialog.cc View 1 chunk +0 lines, -487 lines 0 comments Download
M chrome/chrome_browser.gypi View 6 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Emmanuel Saint-loubert-Bié
Less code is better :-)
9 years, 1 month ago (2011-11-11 01:54:28 UTC) #1
sky
Nice LGTM
9 years, 1 month ago (2011-11-11 02:46:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/8526019/1
9 years, 1 month ago (2011-11-11 02:49:48 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-11 04:00:22 UTC) #4
Change committed as 109581

Powered by Google App Engine
This is Rietveld 408576698