Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 8526018: [Sync] Remove logging/checks for case where server and local entries mismatch. (Closed)

Created:
9 years, 1 month ago by Nicolas Zea
Modified:
9 years, 1 month ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Visibility:
Public.

Description

[Sync] Remove logging/checks for case where server and local entries mismatch. We will now reliably hit this code due to the server changing the MTIME of any committed item. As a result of this, and because the check and log is expensive, it's better to just remove them altogether. BUG=103838 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109761

Patch Set 1 #

Patch Set 2 : Modify testserver. Fix VerifyUpdates #

Total comments: 2

Patch Set 3 : Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -90 lines) Patch
M chrome/browser/sync/engine/process_updates_command.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/sync/engine/syncer_util.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/sync/engine/syncer_util.cc View 1 2 chunks +0 lines, -73 lines 0 comments Download
M net/tools/testserver/chromiumsync.py View 1 2 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nicolas Zea
PTAL. I had to remove both cases we discussed. I verified that, with the testserver ...
9 years, 1 month ago (2011-11-11 02:22:12 UTC) #1
ncarter (slow)
lgtm LGTM; but are there really no test changes required? http://codereview.chromium.org/8526018/diff/2001/net/tools/testserver/chromiumsync.py File net/tools/testserver/chromiumsync.py (right): http://codereview.chromium.org/8526018/diff/2001/net/tools/testserver/chromiumsync.py#newcode470 ...
9 years, 1 month ago (2011-11-11 03:07:53 UTC) #2
Nicolas Zea
Done. Committing once trybots go green (and no, there didn't appear to be any test ...
9 years, 1 month ago (2011-11-11 19:23:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/8526018/7001
9 years, 1 month ago (2011-11-12 01:33:25 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-12 02:46:34 UTC) #5
Change committed as 109761

Powered by Google App Engine
This is Rietveld 408576698