Intrinsify StringBase.isEmpty and inline StringBase.get:length.

runtime/vm/opt_code_generator_ia32.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/opt_code_generator.h"
 
 #include "vm/assembler_macros.h"
@@ skipping 129 matching lines @@
   Label* label() { return &label_; }
 
  private:
   const AstNode* node_;
   GrowableArray<Register> registers_;
   Label label_;
 
   DISALLOW_COPY_AND_ASSIGN(DeoptimizationBlob);
 };
 
-// TODO(srdjan): Add String_get:length, String_charCodeAt, String_hashCode.
+// TODO(srdjan): Add String_charCodeAt, String_hashCode.
 
 #define RECOGNIZED_LIST(V)                                                     \
   V(ObjectArray, get:length, ObjectArrayLength)                                \
   V(GrowableObjectArray, get:length, GrowableArrayLength)                      \
+  V(StringBase, get:length, StringBaseLength)                                  \
   V(IntegerImplementation, toDouble, IntegerToDouble)                          \
   V(Double, toDouble, DoubleToDouble)                                          \
   V(Math, sqrt, MathSqrt)                                                      \
 
 // Class that recognizes the name and owner of a function and returns the
 // corresponding enum. See RECOGNIZED_LIST above for list of recognizable
 // functions.
 class Recognizer : public AllStatic {
  public:
   enum Kind {
     kUnknown,
 #define DEFINE_ENUM_LIST(class_name, function_name, enum_name) k##enum_name,
 RECOGNIZED_LIST(DEFINE_ENUM_LIST)
 #undef DEFINE_ENUM_LIST
   };
 
+  // TODO(srdjan): Check that the library is the coreimpl one.
   static Kind RecognizeKind(const Function& function) {
     const String& recognize_name = String::Handle(function.name());
     const String& recognize_class =
          String::Handle(Class::Handle(function.owner()).Name());
     String& test_function_name = String::Handle();
     String& test_class_name = String::Handle();
 #define RECOGNIZE_FUNCTION(class_name, function_name, enum_name)               \
     test_function_name = String::NewSymbol(#function_name);                    \
     test_class_name = String::NewSymbol(#class_name);                          \
     if (recognize_name.Equals(test_function_name) &&                           \
@@ skipping 1146 matching lines @@
       return;
     }
     case Recognizer::kGrowableArrayLength: {
       TraceOpt(node, "Inlines GrowableObjectArray.length");
       intptr_t field_offset = GetFieldOffset(
           cls,
           String::Handle(String::NewSymbol(kGrowableArrayLengthFieldName)));
       __ movl(EAX, FieldAddress(EBX, field_offset));
       return;
     }
+    case Recognizer::kStringBaseLength: {
+      TraceOpt(node, "Inlines StringBase.length");
+      __ movl(EAX, FieldAddress(EBX, String::length_offset()));
+      return;
+    }
     default:
       UNIMPLEMENTED();
   }
   UNREACHABLE();
 }
 
 
 static bool IsInlineableInstanceGetter(const Function& function) {
   if (function.kind() == RawFunction::kImplicitGetter) {
     return true;
   }
   Recognizer::Kind recognized = Recognizer::RecognizeKind(function);
   if ((recognized == Recognizer::kObjectArrayLength) ||
-      (recognized == Recognizer::kGrowableArrayLength)) {
+      (recognized == Recognizer::kGrowableArrayLength) ||
+      (recognized == Recognizer::kStringBaseLength)) {
     return true;
   }
   return false;
 }
 
 
 // Return the unique target of all checks or null.
 static RawFunction* GetUniqueTarget(const ICData& ic_data) {
   Function& prev_target = Function::Handle();
   Function& target = Function::Handle();
@@ skipping 1078 matching lines @@
   __ addl(ESP, Immediate(node->arguments()->length() * kWordSize));
   // Result is in EAX.
   if (IsResultNeeded(node)) {
     __ pushl(EAX);
   }
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32