Issue 8525018: switch to DVLOG from VLOG, and move struct definition to cc file

Issue 8525018: switch to DVLOG from VLOG, and move struct definition to cc file (Closed)

Created:
9 years, 1 month ago by wjia(left Chromium)

Modified:
9 years, 1 month ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, acolwell+watch_chromium.org, annacc+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

switch to DVLOG from VLOG, and move struct definition to cc file. Clean up the code a bit. BUG=none TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109572

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -102 lines)			Patch
M	content/browser/renderer_host/media/media_stream_dispatcher_host.h	View		1 chunk	+1 line, -10 lines	0 comments	Download
M	content/browser/renderer_host/media/media_stream_dispatcher_host.cc	View		8 chunks	+34 lines, -23 lines	0 comments	Download
M	content/browser/renderer_host/media/media_stream_manager.h	View		1 chunk	+1 line, -19 lines	0 comments	Download
M	content/browser/renderer_host/media/media_stream_manager.cc	View	1	2 chunks	+31 lines, -17 lines	0 comments	Download
M	content/renderer/media/media_stream_dispatcher.h	View		1 chunk	+2 lines, -19 lines	0 comments	Download
M	content/renderer/media/media_stream_dispatcher.cc	View		6 chunks	+28 lines, -13 lines	0 comments	Download
M	content/renderer/media/video_capture_message_filter.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

LGTM w/ one nit also could you clarify your CL description a bit more? If ...

9 years, 1 month ago (2011-11-11 01:44:42 UTC) #2

wjia(left Chromium)

http://codereview.chromium.org/8525018/diff/1/content/browser/renderer_host/media/media_stream_manager.cc File content/browser/renderer_host/media/media_stream_manager.cc (right): http://codereview.chromium.org/8525018/diff/1/content/browser/renderer_host/media/media_stream_manager.cc#newcode60 content/browser/renderer_host/media/media_stream_manager.cc:60: MediaStreamRequester* requester, const StreamOptions& request_options) On 2011/11/11 01:44:43, scherkus ...

9 years, 1 month ago (2011-11-11 01:51:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjia@chromium.org/8525018/7001

9 years, 1 month ago (2011-11-11 01:51:16 UTC) #4

Change committed as 109572

Expand Messages | Collapse Messages