Get all the resources relative to a single base. Currently the same base

Get all the resources relative to a single base.  Currently the same base
URL used for the link resources.  In the future that base will be the pnacl
manifest file.
BUG= none
TEST= none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109659

[sehr (please use chromium), 2011-11-11 00:39:00]

On 2011/11/10 23:57:36, sehr wrote:

Corrected the incorrect removal of crtbegin.o/crtend.o.  PTAL.

[jvoung - send to chromium..., 2011-11-11 00:40:57]

http://codereview.chromium.org/8525014/diff/1/ppapi/native_client/src/trusted...
File ppapi/native_client/src/trusted/plugin/plugin.cc (left):

http://codereview.chromium.org/8525014/diff/1/ppapi/native_client/src/trusted...
ppapi/native_client/src/trusted/plugin/plugin.cc:1613: if
(SelectLLCURLFromManifest(&llc_url, &error_info) &&
Should SelectLLCURLFromManifest (and for LD) be removed now too (since it is not
used) ?

http://codereview.chromium.org/8525014/diff/1/ppapi/native_client/src/trusted...
File ppapi/native_client/src/trusted/plugin/pnacl_resources.cc (right):

http://codereview.chromium.org/8525014/diff/1/ppapi/native_client/src/trusted...
ppapi/native_client/src/trusted/plugin/pnacl_resources.cc:72:
resource_urls_[i]);
could also pass the full_url here, and avoid re-concatenating it in
ResourceReady.

[sehr (please use chromium), 2011-11-11 01:01:18]

Thanks for the review.  PTAL.

http://codereview.chromium.org/8525014/diff/1/ppapi/native_client/src/trusted...
File ppapi/native_client/src/trusted/plugin/plugin.cc (left):

http://codereview.chromium.org/8525014/diff/1/ppapi/native_client/src/trusted...
ppapi/native_client/src/trusted/plugin/plugin.cc:1613: if
(SelectLLCURLFromManifest(&llc_url, &error_info) &&
On 2011/11/11 00:40:57, jvoung wrote:
> Should SelectLLCURLFromManifest (and for LD) be removed now too (since it is
not
> used) ?

Duh. Of course I should have.  Done.

http://codereview.chromium.org/8525014/diff/1/ppapi/native_client/src/trusted...
File ppapi/native_client/src/trusted/plugin/pnacl_resources.cc (right):

http://codereview.chromium.org/8525014/diff/1/ppapi/native_client/src/trusted...
ppapi/native_client/src/trusted/plugin/pnacl_resources.cc:72:
resource_urls_[i]);
On 2011/11/11 00:40:57, jvoung wrote:
> could also pass the full_url here, and avoid re-concatenating it in
> ResourceReady.

Done.

[jvoung - send to chromium..., 2011-11-11 01:11:22]

http://codereview.chromium.org/8525014/diff/1006/ppapi/native_client/src/trus...
File ppapi/native_client/src/trusted/plugin/plugin.cc (right):

http://codereview.chromium.org/8525014/diff/1006/ppapi/native_client/src/trus...
ppapi/native_client/src/trusted/plugin/plugin.cc:1709: return
manifest_->GetLLCURL(result, error_info);
Sorry, there's also manifest_->GetLLCURL and kPnaclLlcKey, etc. in manifest.cc.

[sehr (please use chromium), 2011-11-11 15:55:31]

Thanks again.  Sorry for the oversights.  PTAL.

http://codereview.chromium.org/8525014/diff/1006/ppapi/native_client/src/trus...
File ppapi/native_client/src/trusted/plugin/plugin.cc (right):

http://codereview.chromium.org/8525014/diff/1006/ppapi/native_client/src/trus...
ppapi/native_client/src/trusted/plugin/plugin.cc:1709: return
manifest_->GetLLCURL(result, error_info);
On 2011/11/11 01:11:22, jvoung wrote:
> Sorry, there's also manifest_->GetLLCURL and kPnaclLlcKey, etc. in
manifest.cc.

Sorry I missed that.  Thanks for catching it.

[jvoung - send to chromium..., 2011-11-11 18:01:21]

lgtm

[sehr (please use chromium), 2011-11-11 18:51:17]

On 2011/11/11 18:01:21, jvoung wrote:
> lgtm

Thanks.  r109659.