Issue 8525012: dbus: Fix a bug where we rejected an empty array in PopArrayOfBytes()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8525012: dbus: Fix a bug where we rejected an empty array in PopArrayOfBytes() (Closed)

Created:
9 years, 1 month ago by satorux1

Modified:
9 years, 1 month ago

Reviewers:
stevenjb

CC:
chromium-reviews, Paweł Hajdan Jr., kliegs

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

dbus: Fix a bug where we rejected an empty array in PopArrayOfBytes() An empty array should be allowed. Sometimes, you need to send an empty array from methods and signals. BUG=103793 TEST=added a test in dbus_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109561

Patch Set 1 #

Patch Set 2 : minor change #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -1 line)			Patch
	M	dbus/message.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download
	M	dbus/message_unittest.cc	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/8525012/4

9 years, 1 month ago (2011-11-11 00:52:38 UTC) #4

Change committed as 109561

Expand Messages | Collapse Messages