Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 8525002: Provide access to stdin, stdout and stderr (Closed)

Created:
9 years, 1 month ago by Søren Gjesse
Modified:
9 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Provide access to stdin, stdout and stderr R=ager@google.com, iposva@google.com BUG=dart:402 TEST= Committed: https://code.google.com/p/dart/source/detail?r=1456

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed issue with Dart not stopping #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -5 lines) Patch
M runtime/bin/builtin.dart View 1 1 chunk +27 lines, -0 lines 1 comment Download
M runtime/bin/process_impl.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/bin/socket_impl.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
This is a proposed solution for providing access to stdin, stdout and stderr. This is ...
9 years, 1 month ago (2011-11-10 17:44:42 UTC) #1
Mads Ager (google)
Makes sense to me. I think we should finish this and put it in. What ...
9 years, 1 month ago (2011-11-10 18:08:51 UTC) #2
Søren Gjesse
Fixed the issue with Dart not stopping when stdio streams where closed. Renamed a few ...
9 years, 1 month ago (2011-11-11 11:33:20 UTC) #3
Mads Ager (google)
9 years, 1 month ago (2011-11-11 11:37:36 UTC) #4
lgtm

http://codereview.chromium.org/8525002/diff/4001/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

http://codereview.chromium.org/8525002/diff/4001/runtime/bin/builtin.dart#new...
runtime/bin/builtin.dart:18: Socket _stdin ;
Remove space before ';'.

Powered by Google App Engine
This is Rietveld 408576698