Fix sad tab in native_widget_views

Fix sad tab in native_widget_views

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110112

[sadrul, 2011-11-14 17:23:04]

Sorry for the delayed review. Please ping over IM if I don't review within the
day.

http://codereview.chromium.org/8524020/diff/1/views/widget/native_widget_view...
File views/widget/native_widget_views.cc (right):

http://codereview.chromium.org/8524020/diff/1/views/widget/native_widget_view...
views/widget/native_widget_views.cc:356: // |bounds| are supplied in the
coordinates of the parent.
Update the comment here explaining that for toplevel widgets, it is necessary to
set the bounds on NativeWidgetView in screen coordinate system, but doing so is
not necessary for control widgets.

http://codereview.chromium.org/8524020/diff/1/views/widget/native_widget_view...
views/widget/native_widget_views.cc:358: view_->SetBoundsRect(bounds);
Is it sufficient to just check for !GetWidget()->is_top_level()? Or does that
break tooltip positioning?

[pkotwicz, 2011-11-14 20:28:37]

It seems as if it is sufficient. The parent_widget parameter is not being set
for tooltips.

I have also tested tooltips with use_views_toolkit=1 and they are in the proper
position

[sadrul, 2011-11-14 20:49:42]

Excellent. Thanks! LGTM