Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8524016: webkit: Remove 1 exit time destructor and turn on -Wexit-time-destructors. (Closed)

Created:
9 years, 1 month ago by Nico
Modified:
9 years, 1 month ago
CC:
chromium-reviews, michaeln, kinuko+watch, darin-cc_chromium.org
Visibility:
Public.

Description

webkit: Remove 3 exit time destructor and turn on -Wexit-time-destructors. BUG=101600 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109700

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M webkit/appcache/webkit_appcache.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/blob/webkit_blob.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M webkit/database/webkit_database.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/fileapi/webkit_fileapi.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M webkit/gpu/webkit_gpu.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/quota/webkit_quota.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/support/platform_support_linux.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/support/platform_support_mac.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/support/webkit_support.gypi View 3 chunks +3 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/simple_socket_stream_bridge.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Nico
9 years, 1 month ago (2011-11-11 01:13:21 UTC) #1
Nico
kbr, can you take a quick look? Looks like apatrick isn't in yet.
9 years, 1 month ago (2011-11-11 19:56:07 UTC) #2
apatrick_chromium
On 2011/11/11 19:56:07, Nico wrote: > kbr, can you take a quick look? Looks like ...
9 years, 1 month ago (2011-11-11 20:02:11 UTC) #3
apatrick_chromium
http://codereview.chromium.org/8524016/diff/11/webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc File webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc (right): http://codereview.chromium.org/8524016/diff/11/webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc#newcode411 webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc:411: CR_DEFINE_STATIC_LOCAL(scoped_refptr<gfx::GLShareGroup>, share_group, I think I missed the memo. Why?
9 years, 1 month ago (2011-11-11 20:05:23 UTC) #4
Nico
http://codereview.chromium.org/8524016/diff/11/webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc File webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc (right): http://codereview.chromium.org/8524016/diff/11/webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc#newcode411 webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc:411: CR_DEFINE_STATIC_LOCAL(scoped_refptr<gfx::GLShareGroup>, share_group, On 2011/11/11 20:05:23, apatrick_chromium wrote: > I ...
9 years, 1 month ago (2011-11-11 20:07:19 UTC) #5
apatrick_chromium
Rubber stamp LGTM.
9 years, 1 month ago (2011-11-11 20:11:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8524016/11
9 years, 1 month ago (2011-11-11 20:14:14 UTC) #7
commit-bot: I haz the power
Can't apply patch for file webkit/blob/webkit_blob.gypi. While running patch -p1 --forward --force; patching file webkit/blob/webkit_blob.gypi ...
9 years, 1 month ago (2011-11-11 20:14:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8524016/7002
9 years, 1 month ago (2011-11-11 20:18:47 UTC) #9
Ken Russell (switch to Gerrit)
LGTM FWIW.
9 years, 1 month ago (2011-11-11 20:45:38 UTC) #10
commit-bot: I haz the power
9 years, 1 month ago (2011-11-11 21:29:29 UTC) #11 
Change committed as 109700

Powered by Google App Engine
This is Rietveld 408576698